feat: ListRolesForPAT proto definition#448
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new RPC endpoint Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 2866-2868: ListRolesForPATRequest currently only has repeated
string scopes, causing ambiguous org-specific role discovery; update the
protobuf message ListRolesForPATRequest to include an organization context field
(e.g., string organization or string org_id) analogous to the org-scoped
CreateCurrentUserPATRequest so callers can pass the target org when listing PAT
roles; ensure the new field number is unique within ListRolesForPATRequest and
update any relevant RPC handlers/serializers that consume ListRolesForPATRequest
to read and enforce the organization value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f778a820-aa86-40e8-9ff7-b26d9a9d6e60
📒 Files selected for processing (1)
raystack/frontier/v1beta1/frontier.proto
Summary by CodeRabbit