Skip to content

feat: ListRolesForPAT proto definition#448

Merged
AmanGIT07 merged 3 commits intomainfrom
feat/list-pat-roles-proto
Mar 17, 2026
Merged

feat: ListRolesForPAT proto definition#448
AmanGIT07 merged 3 commits intomainfrom
feat/list-pat-roles-proto

Conversation

@AmanGIT07
Copy link
Contributor

@AmanGIT07 AmanGIT07 commented Mar 17, 2026

Summary by CodeRabbit

  • New Features
    • Added ability to retrieve roles associated with Personal Access Tokens filtered by specified scopes. This enables better access control management and visibility into PAT permissions.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@AmanGIT07 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 32dd970c-3e7c-4419-a1cd-45d9b032be6b

📥 Commits

Reviewing files that changed from the base of the PR and between 5cda45a and b3dcbe9.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto
📝 Walkthrough

Walkthrough

A new RPC endpoint ListRolesForPAT is added to the FrontierService in the protobuf definition, along with corresponding request and response message types. This enables querying roles associated with Personal Access Tokens scoped to specific permissions.

Changes

Cohort / File(s) Summary
PAT Role Lookup Service
raystack/frontier/v1beta1/frontier.proto
Adds ListRolesForPAT RPC method to FrontierService with ListRolesForPATRequest (accepts scopes) and ListRolesForPATResponse (returns roles) message types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • whoAbhishekSah

Poem

🐰 A proto so neat, with roles in the pocket,
PATs now can speak: "What scopes? Let me rock it!"
New messages bloom, a service takes flight,
Frontier hops forward—permissions done right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: ListRolesForPAT proto definition' clearly and specifically describes the main change: adding a new ListRolesForPAT proto definition to the frontier service.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/list-pat-roles-proto
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 2866-2868: ListRolesForPATRequest currently only has repeated
string scopes, causing ambiguous org-specific role discovery; update the
protobuf message ListRolesForPATRequest to include an organization context field
(e.g., string organization or string org_id) analogous to the org-scoped
CreateCurrentUserPATRequest so callers can pass the target org when listing PAT
roles; ensure the new field number is unique within ListRolesForPATRequest and
update any relevant RPC handlers/serializers that consume ListRolesForPATRequest
to read and enforce the organization value.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f778a820-aa86-40e8-9ff7-b26d9a9d6e60

📥 Commits

Reviewing files that changed from the base of the PR and between 4d970a5 and 5cda45a.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

@AmanGIT07 AmanGIT07 merged commit 05684da into main Mar 17, 2026
3 checks passed
@AmanGIT07 AmanGIT07 deleted the feat/list-pat-roles-proto branch March 17, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants