-
Notifications
You must be signed in to change notification settings - Fork 44
feat: update apsara to 1.0.0-rc.5 #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,9 +22,7 @@ export interface TransformOptions { | |
| /** | ||
| * Converts a filter value to the appropriate RQLFilter value format | ||
| */ | ||
| function convertFilterValue( | ||
| value: string | number | boolean | null | undefined, | ||
| ): RQLFilter["value"] { | ||
| function convertFilterValue(value: unknown): RQLFilter["value"] { | ||
| switch (typeof value) { | ||
| case "boolean": | ||
| return { case: "boolValue", value }; | ||
|
|
@@ -33,7 +31,7 @@ function convertFilterValue( | |
| case "string": | ||
| return { case: "stringValue", value }; | ||
| default: | ||
| return { case: "stringValue", value: value ?? "" }; | ||
| return { case: "stringValue", value: value == null ? "" : String(value) }; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Find usages of DataTableQuery filters and test coverage for convertFilterValue
# Check for test files covering this utility
fd -e test.ts -e test.tsx -e spec.ts | xargs rg -l 'convertFilterValue|transformDataTableQueryToRQLRequest'
# Look for actual filter.value usage patterns in the codebase
rg -n -C3 'filters.*value' --type=ts --type=tsx -g '!node_modules' -g '!dist'
# Check DataTableFilter type definition from Apsara (if locally installed)
rg -n 'export.*DataTableFilter' --type=ts -g '**/apsara*/**'Repository: raystack/frontier Length of output: 238 🏁 Script executed: #!/bin/bash
# Find test files and search for test coverage
echo "=== Test files mentioning transform-query or convertFilterValue ==="
find web -name "*test*" -o -name "*spec*" | head -20
echo "=== Search for tests covering this transformation ==="
rg -n "convertFilterValue|transformDataTableQueryToRQLRequest" web --type ts -g "*.test.ts" -g "*.spec.ts"
echo "=== Look for DataTableFilter type definition ==="
rg -n "interface DataTableFilter|type DataTableFilter|export.*DataTableFilter" web --type ts
echo "=== Check actual filter.value usage patterns ==="
rg -n "filter\.value|filters\[.*\]\.value" web --type ts -A2 -B2
echo "=== Examine the transform-query.ts file to understand context ==="
cat -n web/sdk/react/utils/transform-query.ts | head -50Repository: raystack/frontier Length of output: 3731 🏁 Script executed: #!/bin/bash
echo "=== Check if Apsara is installed and find its types ==="
find web -path "*/node_modules/@raystack/apsara*" -name "*.d.ts" 2>/dev/null | head -5
echo "=== Search for examples of filter creation/usage with specific types ==="
rg -n "DataTableFilter|filters.*:" web --type ts -B2 -A2 | head -60
echo "=== Look for any object or array being passed as filter value ==="
rg -n "value:.*\{|\[.*\]" web --type ts -g "!node_modules" | head -30
echo "=== Check if there are date range or date filters documented ==="
rg -n "dateValue|DateRange|dateRange|date.*filter" web --type ts -i | head -20
echo "=== Search for how filters are actually created in the frontend ==="
fd -e test.ts -e test.tsx | xargs rg -l "filter" 2>/dev/null | head -5
echo "=== Look at the admin app transform-query for more context ==="
head -70 web/apps/admin/src/utils/transform-query.tsRepository: raystack/frontier Length of output: 9224 🏁 Script executed: #!/bin/bash
echo "=== Compare both versions side-by-side ==="
echo "Admin app version (web/apps/admin/src/utils/transform-query.ts lines 24-30):"
sed -n '24,30p' web/apps/admin/src/utils/transform-query.ts
echo ""
echo "React SDK version (web/sdk/react/utils/transform-query.ts lines 25-35):"
sed -n '25,35p' web/sdk/react/utils/transform-query.ts
echo ""
echo "=== Check SDK utils version ==="
sed -n '25,35p' web/sdk/utils/transform-query.ts
echo ""
echo "=== Search for any test files that might test this conversion ==="
find web -name "*.test.ts" -o -name "*.test.tsx" | xargs grep -l "convertFilterValue\|transformDataTableQuery" 2>/dev/null
echo ""
echo "=== Look for usage of filter.value with complex types ==="
rg -n "filter\.value\s*=" web --type ts -B3 -A3Repository: raystack/frontier Length of output: 1328 Verify type safety regression in The function's parameter type was changed from Align this with the other implementations by either:
|
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
What are the breaking changes in@raystack/apsaraversion 1.0.0-rc.3, 1.0.0-rc.4, and 1.0.0-rc.5?💡 Result:
No specific breaking changes documented for
@raystack/apsaraversions 1.0.0-rc.3, 1.0.0-rc.4, or 1.0.0-rc.5 in available sources. The latest release found is v1.0.0-rc.2 on 2026-03-30 [1]. Ongoing work includes modernizing to React 19, dropping React 18 support by removing deprecated forwardRef wrappers from 63 components, updating peer deps to react@^19, and removing displayName assignments, noted as a breaking change requiring React upgrade [2]. TypeScript improvements like eliminating any types and@ts-ignorealso in progress, potentially breaking for type consumers [3]. npm shows versions up to 0.56.6, no 1.0 rc listings [4]. Check GitHub releases https://github.com/raystack/apsara/releases and issues for latest [1].Citations:
🏁 Script executed:
Repository: raystack/frontier
Length of output: 640
🌐 Web query:
@raystack/apsara npm releases rc.3 rc.4 rc.5💡 Result:
I couldn’t find evidence that
@raystack/apsarahas npm prerelease versions literally named rc.3, rc.4, and rc.5 (for example, 1.0.0-rc.3 / 1.0.0-rc.4 / 1.0.0-rc.5). What I can confirm from npm’s registry page is that the package has prerelease versions using the “-rc” suffix, and that as of the version-history table it includes a range like “0.55.0-rc.1 - 0.55.0-rc.4” (no rc.5 shown in the snippet I can access) and the latest published version listed there is v0.56.6 [1]. On the GitHub repository page, the “Latest release” shown there is “v1.0.0-rc.2” (prerelease), which again doesn’t demonstrate rc.3/rc.4/rc.5 specifically [2]. If you tell me what version line you mean (e.g., “0.55.x rc.3/rc.4/rc.5” vs “1.0.0-rc.3/rc.4/rc.5”), I can rerun the search with the exact version strings.Citations:
🏁 Script executed:
Repository: raystack/frontier
Length of output: 84
🏁 Script executed:
# Check the CHANGELOG for version history head -100 web/sdk/CHANGELOG.mdRepository: raystack/frontier
Length of output: 584
🏁 Script executed:
Repository: raystack/frontier
Length of output: 133
🏁 Script executed:
Repository: raystack/frontier
Length of output: 5973
Check for breaking changes in rc.3, rc.4, and rc.5.
The PR migrates from rc.2 to rc.5, skipping rc.3 and rc.4. While the
InputField→Field+Inputmigration is already handled, the release notes document additional breaking changes:asprop replaced withrenderprop in Text and Headline components; Command component migrated to Base UI; Textarea size/variant API changesoverlay-base-primarytoken removed; Input component improvementsVerify that these changes are accounted for in the codebase integrations.