Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRefactors list views for API keys, projects, and teams by removing column-level clickable title handlers, rendering titles as non-interactive text, adding explicit stopPropagation on action handlers, and wiring row interactions via DataTable's onRowClick. Also adds data-test-id attributes and explicit React imports. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request Test Coverage Report for Build 23231945164Details
💛 - Coveralls |
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
web/sdk/react/views/projects/list/projects-columns.tsx (1)
85-89: Wrap the trigger icon in a focusable element for keyboard accessibility.The
DropdownMenu.TriggerwithasChilddirectly wrapsDotsHorizontalIcon(an SVG), which is not natively focusable. This prevents keyboard users from accessing the dropdown menu. Wrap the icon in a<button>element to ensure proper focus handling and keyboard navigation.Additionally, the
@ts-ignorecomment on line 88 should include a brief explanation of why type checking is being suppressed.♻️ Suggested improvement
<DropdownMenu.Trigger asChild style={{ cursor: 'pointer' }}> - <DotsHorizontalIcon /> + <button type="button" aria-label="Project actions"> + <DotsHorizontalIcon /> + </button> </DropdownMenu.Trigger> - {/* `@ts-ignore` */} + {/* `@ts-ignore` - portal prop type mismatch with Apsara version */} <DropdownMenu.Content portal={false}>Note: This pattern appears in multiple files across the codebase (member-columns.tsx, team-member-columns.tsx, teams-columns.tsx, etc.) and should be addressed consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d07b07b4-9613-4a2c-88b3-910aad5e6bff
📒 Files selected for processing (6)
web/sdk/react/views/api-keys/list/api-keys-columns.tsxweb/sdk/react/views/api-keys/list/api-keys-list-page.tsxweb/sdk/react/views/projects/list/projects-columns.tsxweb/sdk/react/views/projects/list/projects-list-page.tsxweb/sdk/react/views/teams/list/teams-columns.tsxweb/sdk/react/views/teams/list/teams-list-page.tsx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This PR makes the entire row clickable in the Projects, Teams, and Service Account tables.
Instead of clicking the title, the user can click the entire row to navigate to the details page.
Some minor linting changes are also made due to the editor lint on save feature.