Skip to content

fix(sdk): make whole row clickable#1458

Open
rsbh wants to merge 5 commits intomainfrom
fix_sdk_row_clickable
Open

fix(sdk): make whole row clickable#1458
rsbh wants to merge 5 commits intomainfrom
fix_sdk_row_clickable

Conversation

@rsbh
Copy link
Member

@rsbh rsbh commented Mar 18, 2026

This PR makes the entire row clickable in the Projects, Teams, and Service Account tables.
Instead of clicking the title, the user can click the entire row to navigate to the details page.

Some minor linting changes are also made due to the editor lint on save feature.

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 18, 2026 6:22am

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6d42be2d-3486-4f3c-8561-f9294ad6a62a

📥 Commits

Reviewing files that changed from the base of the PR and between 3c5291b and fe135d8.

📒 Files selected for processing (1)
  • web/sdk/react/views/teams/list/teams-list-page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/sdk/react/views/teams/list/teams-list-page.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Unified row-click behavior in API keys, projects, and teams lists so clicking a row opens the item, replacing prior column-specific click handling.
    • Simplified title and member cells to non-interactive text for clearer interaction targets.
  • Bug Fixes
    • Delete/rename actions now stop click propagation to prevent accidental row navigation when using action controls.

Walkthrough

Refactors list views for API keys, projects, and teams by removing column-level clickable title handlers, rendering titles as non-interactive text, adding explicit stopPropagation on action handlers, and wiring row interactions via DataTable's onRowClick. Also adds data-test-id attributes and explicit React imports.

Changes

Cohort / File(s) Summary
API Keys
web/sdk/react/views/api-keys/list/api-keys-columns.tsx, web/sdk/react/views/api-keys/list/api-keys-list-page.tsx
Removed onServiceAccountClick from GetColumnsOptions and getColumns signature; replaced clickable Title cell with plain Text; added stopPropagation to delete action; wired row navigation via DataTable onRowClick in list page.
Projects
web/sdk/react/views/projects/list/projects-columns.tsx, web/sdk/react/views/projects/list/projects-list-page.tsx
Replaced clickable Title/Members cells with non-interactive Text; extracted action handlers (rename/delete) to stop propagation and delegate to callbacks; added data-test-id attributes; moved navigation to DataTable onRowClick.
Teams
web/sdk/react/views/teams/list/teams-columns.tsx, web/sdk/react/views/teams/list/teams-list-page.tsx
Split composite column into Title, Members, and Actions; Title rendered as plain Text; action handlers updated to stopPropagation and include data-test-id attributes; list page wired row clicks to onRowClick for team navigation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • paanSinghCoder
  • rohanchkrabrty
  • rohilsurana
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Mar 18, 2026

Pull Request Test Coverage Report for Build 23231945164

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.775%

Totals Coverage Status
Change from base Build 23189815517: 0.0%
Covered Lines: 14321
Relevant Lines: 35122

💛 - Coveralls

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Nitpick comments (1)
web/sdk/react/views/projects/list/projects-columns.tsx (1)

85-89: Wrap the trigger icon in a focusable element for keyboard accessibility.

The DropdownMenu.Trigger with asChild directly wraps DotsHorizontalIcon (an SVG), which is not natively focusable. This prevents keyboard users from accessing the dropdown menu. Wrap the icon in a <button> element to ensure proper focus handling and keyboard navigation.

Additionally, the @ts-ignore comment on line 88 should include a brief explanation of why type checking is being suppressed.

♻️ Suggested improvement
       <DropdownMenu.Trigger asChild style={{ cursor: 'pointer' }}>
-        <DotsHorizontalIcon />
+        <button type="button" aria-label="Project actions">
+          <DotsHorizontalIcon />
+        </button>
       </DropdownMenu.Trigger>
-      {/* `@ts-ignore` */}
+      {/* `@ts-ignore` - portal prop type mismatch with Apsara version */}
       <DropdownMenu.Content portal={false}>

Note: This pattern appears in multiple files across the codebase (member-columns.tsx, team-member-columns.tsx, teams-columns.tsx, etc.) and should be addressed consistently.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d07b07b4-9613-4a2c-88b3-910aad5e6bff

📥 Commits

Reviewing files that changed from the base of the PR and between 44a30fc and 3c5291b.

📒 Files selected for processing (6)
  • web/sdk/react/views/api-keys/list/api-keys-columns.tsx
  • web/sdk/react/views/api-keys/list/api-keys-list-page.tsx
  • web/sdk/react/views/projects/list/projects-columns.tsx
  • web/sdk/react/views/projects/list/projects-list-page.tsx
  • web/sdk/react/views/teams/list/teams-columns.tsx
  • web/sdk/react/views/teams/list/teams-list-page.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@rsbh rsbh changed the title Fix sdk row clickable fix(sdk): make whole row clickable Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants