fix (admin & sdk): text-area out of bounds when resized#1452
fix (admin & sdk): text-area out of bounds when resized#1452paanSinghCoder wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds CSS styling to TextArea components in two invite dialog interfaces. It applies a new className to email input fields and defines corresponding CSS classes to control textarea resizing and dimensions using CSS variables. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/sdk/react/components/organization/organization.module.css (1)
39-43: Consider consolidating duplicated textarea-resize rules.This block is functionally correct, but it mirrors the admin class almost exactly. A shared utility/style token would reduce drift risk if bounds change later.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 43d7e66b-0c45-46a3-9dc1-34441965f9d8
📒 Files selected for processing (4)
web/sdk/admin/views/organizations/details/layout/invite-users-dialog.tsxweb/sdk/admin/views/organizations/details/layout/layout.module.cssweb/sdk/react/components/organization/organization.module.cssweb/sdk/react/views/members/invite-member-dialog.tsx
Pull Request Test Coverage Report for Build 23183189752Details
💛 - Coveralls |
Summary
fix (admin & sdk): email text-area out of bounds on resize
var(--rs-space-17)(120px).Routes affected:
/organizations/{org-id}/members-> Three dots ->Invite User...dialog.MembersTab ->Invite Usersdk1.mov
sdk2.mov
Changes
Add className
.invite-users-emails-textareato the email text-area with below CSS:Test Plan