Skip to content

fix: paper theme skeleton loader and navbar improvements #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsbh merged 3 commits into from
May 8, 2026
Merged

fix: paper theme skeleton loader and navbar improvements #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d0ba3d
fix: add navbar to skeleton loader
rsbh May 8, 2026
041b103
fix: navbar padding
rsbh May 8, 2026
d13169a
fix: icon for navbar
rsbh May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/chronicle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@opentelemetry/resources": "^2.6.1",
"@opentelemetry/sdk-metrics": "^2.6.1",
"@opentelemetry/semantic-conventions": "^1.40.0",
"@radix-ui/react-icons": "^1.3.2",
"@raystack/apsara": "1.0.0-rc.4",
"@shikijs/rehype": "^4.0.2",
"@vitejs/plugin-react": "^6.0.1",
Expand Down
9 changes: 7 additions & 2 deletions packages/chronicle/src/themes/paper/Page.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.main {
flex: 1;
width: 90%;
width: 100%;
max-width: calc(1024px + var(--rs-space-17));
margin: 0 auto;
padding-top: var(--rs-space-12);
Expand Down Expand Up @@ -137,8 +137,8 @@
box-shadow:
0 1px 3px rgba(0, 0, 0, 0.08),
0 4px 12px rgba(0, 0, 0, 0.04);
margin-bottom: var(--rs-space-9);
min-height: calc(100vh - var(--rs-space-12));
margin: 0 var(--rs-space-7) var(--rs-space-9) var(--rs-space-7);
}

.content h1,
Expand Down Expand Up @@ -225,5 +225,10 @@
}

.loader {
flex: 1;
margin-bottom: var(--rs-space-3)
}

.navbarLoaderWrapper {
width: 30%;
}
14 changes: 8 additions & 6 deletions packages/chronicle/src/themes/paper/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import {
ArrowLeftIcon,
ArrowRightIcon,
AdjustmentsHorizontalIcon,
EyeIcon,
SunIcon,
MoonIcon,
XMarkIcon,
} from '@heroicons/react/24/outline';
import {
ArrowLeftIcon,
ArrowRightIcon,
MixerHorizontalIcon,
Cross2Icon
} from '@radix-ui/react-icons'
import { IconButton, useTheme } from '@raystack/apsara';
import { useEffect, useMemo, useState } from 'react';
import { Link as RouterLink, useLocation } from 'react-router';
Expand Down Expand Up @@ -83,12 +85,12 @@ export function Page({ page, tree }: ThemePageProps) {
</IconButton>
)}
<IconButton size={2} onClick={() => setSettingsOpen(false)} aria-label='Close settings'>
<XMarkIcon width={14} height={14} />
<Cross2Icon width={14} height={14} />
</IconButton>
</>
) : (
<IconButton size={2} onClick={() => setSettingsOpen(true)} aria-label='Open settings'>
<AdjustmentsHorizontalIcon width={14} height={14} />
<MixerHorizontalIcon width={14} height={14} />
</IconButton>
)}
</div>
Expand Down
9 changes: 9 additions & 0 deletions packages/chronicle/src/themes/paper/Skeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
import { Skeleton } from '@raystack/apsara';
import styles from './Page.module.css';
import { cx } from 'class-variance-authority';

export function PageSkeleton() {
return (
<main className={styles.main}>
<div className={styles.navbar}>
<div className={cx(styles.navLeft, styles.navbarLoaderWrapper)}>
<Skeleton highlightColor="var(--rs-color-foreground-base-emphasis)" containerClassName={styles.loader}/>
</div>
<div className={cx(styles.navRight, styles.navbarLoaderWrapper)}>
<Skeleton highlightColor="var(--rs-color-foreground-base-emphasis)" containerClassName={styles.loader}/>
</div>
</div>
<div className={styles.content}>
<header className={styles.articleHeader}>
<Skeleton width="50%" height="16px" containerClassName={styles.headerLoader}/>
Expand Down
Loading