-
Notifications
You must be signed in to change notification settings - Fork 0
feat: skeleton loaders for page navigation #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
87896af
feat: add isLoading state to PageProvider for skeleton loaders
rsbh 8908d22
feat: add skeleton loaders for default and paper themes
rsbh 5f9af64
fix: lint errors — unused import and useless catch
rsbh 7248b74
fix: clear stale page/error before docs fetch for consistent skeleton
rsbh 2ce4d02
refactor: extract IIFE into loadDocsPage useCallback
rsbh a1759cc
refactor: move isLoading to loadDocsPage, keep fetchPageData pure
rsbh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { Skeleton } from '@raystack/apsara'; | ||
| import { Flex } from '@raystack/apsara'; | ||
| import styles from './Page.module.css'; | ||
|
|
||
| export function PageSkeleton() { | ||
| return ( | ||
| <Flex className={styles.page}> | ||
| <article className={styles.article}> | ||
| <Skeleton width="40%" height="32px" /> | ||
| <Skeleton.Provider duration={2}> | ||
| <Skeleton width="100%" height="16px" /> | ||
| <Skeleton width="95%" height="16px" /> | ||
| <Skeleton width="80%" height="16px" /> | ||
| <Skeleton width="100%" height="16px" /> | ||
| <Skeleton width="60%" height="16px" /> | ||
| </Skeleton.Provider> | ||
| <Skeleton width="30%" height="24px" /> | ||
| <Skeleton.Provider duration={2}> | ||
| <Skeleton width="100%" height="16px" /> | ||
| <Skeleton width="90%" height="16px" /> | ||
| <Skeleton width="100%" height="16px" /> | ||
| <Skeleton width="70%" height="16px" /> | ||
| </Skeleton.Provider> | ||
| </article> | ||
| </Flex> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| import type { Theme } from '@/types'; | ||
| import { Layout } from './Layout'; | ||
| import { Page } from './Page'; | ||
| import { PageSkeleton } from './Skeleton'; | ||
| import { Toc } from './Toc'; | ||
|
|
||
| export const defaultTheme: Theme = { | ||
| Layout, | ||
| Page | ||
| Page, | ||
| Skeleton: PageSkeleton, | ||
| }; | ||
|
|
||
| export { Layout, Page, Toc }; | ||
| export { Layout, Page, PageSkeleton, Toc }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { Skeleton } from '@raystack/apsara'; | ||
| import styles from './Page.module.css'; | ||
|
|
||
| export function PageSkeleton() { | ||
| return ( | ||
| <main className={styles.main}> | ||
| <div className={styles.content}> | ||
| <header className={styles.articleHeader}> | ||
| <Skeleton width="50%" height="16px" containerClassName={styles.headerLoader}/> | ||
| <Skeleton width="70%" height="32px" containerClassName={styles.headerLoader}/> | ||
| <Skeleton width="50%" height="16px" containerClassName={styles.headerLoader}/> | ||
| </header> | ||
| <div className={styles.article}> | ||
| { | ||
| [...new Array(30)].map((_, i) => { | ||
| return <Skeleton key={i} width="100%" height="20px" containerClassName={styles.loader}/> | ||
| }) | ||
| } | ||
| </div> | ||
| </div> | ||
| </main> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| import type { Theme } from '@/types'; | ||
| import { Layout } from './Layout'; | ||
| import { Page } from './Page'; | ||
| import { PageSkeleton } from './Skeleton'; | ||
|
|
||
| export const paperTheme: Theme = { | ||
| Layout, | ||
| Page | ||
| Page, | ||
| Skeleton: PageSkeleton, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.