Skip to content

fix(select): set positioner background to prevent overscroll bleed#795

Merged
rohanchkrabrty merged 1 commit intomainfrom
fix/select/overscroll-background-bleed
May 8, 2026
Merged

fix(select): set positioner background to prevent overscroll bleed#795
rohanchkrabrty merged 1 commit intomainfrom
fix/select/overscroll-background-bleed

Conversation

@Shreyag02
Copy link
Copy Markdown
Contributor

Description

The positioner element was transparent, so during touch-overscroll bounce the page's background (or whatever sits behind the popover) showed through the dropdown's edges. It was highly visible in the dark-theme, multiselect example.
Setting it to --rs-color-background-base-primary make the layer opaque so overscroll bouncing no longer reveals what's behind.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

How Has This Been Tested?

visually tested.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

N/A

Related Issues

#736

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 8, 2026 8:01am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22a11a5f-2464-443a-942b-bec87a9963dc

📥 Commits

Reviewing files that changed from the base of the PR and between f8b9b8c and 9dd0aae.

📒 Files selected for processing (1)
  • packages/raystack/components/select/select.module.css

📝 Walkthrough

Walkthrough

This pull request adds a single CSS styling declaration to the Select component's stylesheet. The change introduces a background-color property set to the --rs-color-background-base-primary design token on the .positioner class. This is a styling-only modification that does not alter any component logic, interface, or behavior.

Suggested reviewers

  • rohilsurana
  • paanSinghCoder
  • rsbh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a background color to the positioner element to fix overscroll bleed visibility.
Description check ✅ Passed The description clearly explains the issue (transparent positioner showing page background during overscroll) and the solution (setting background color), directly matching the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty merged commit f0ad7df into main May 8, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix/select/overscroll-background-bleed branch May 8, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants