fix(select): set positioner background to prevent overscroll bleed#795
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds a single CSS styling declaration to the Select component's stylesheet. The change introduces a Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The positioner element was transparent, so during touch-overscroll bounce the page's background (or whatever sits behind the popover) showed through the dropdown's edges. It was highly visible in the dark-theme, multiselect example.
Setting it to --rs-color-background-base-primary make the layer opaque so overscroll bouncing no longer reveals what's behind.
Type of Change
How Has This Been Tested?
visually tested.
Checklist:
Screenshots (if appropriate):
N/A
Related Issues
#736