Skip to content

fix: breaking build and tests#707

Merged
rohanchkrabrty merged 1 commit intomainfrom
fix-toast-export
Mar 17, 2026
Merged

fix: breaking build and tests#707
rohanchkrabrty merged 1 commit intomainfrom
fix-toast-export

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Mar 17, 2026

Summary

  • Fix flaky Select tests by updating close + keyboard navigation assertions.
  • Fix invalid toast export

Summary by CodeRabbit

  • Breaking Changes
    • Updated toast API exports: ToastContainer and toast have been replaced with Toast and toastManager.

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Mar 17, 2026 10:16am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

📝 Walkthrough

Walkthrough

The pull request refactors select component tests to use user-event driven interactions instead of act-based testing, and updates the public API exports to replace ToastContainer and toast with Toast and toastManager.

Changes

Cohort / File(s) Summary
Select Component Test Refactoring
packages/raystack/components/select/__tests__/select.test.tsx
Migrated test interactions from act-based with fireEvent to user-event driven approach. Updated openSelect() to accept a user instance, removed act import, and adjusted all test interactions to use user.click and direct element focus.
Public API Export Updates
packages/raystack/index.tsx
Modified toast-related public exports: removed ToastContainer and toast, added Toast and toastManager as replacements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • paanSinghCoder

Poem

🐰 Whiskers twitching with delight,
Tests now flow with user-event might,
No more acts to clutter the way,
Toast API blooms bright and new today,
A cleaner hop through testing's light!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: breaking build and tests' is vague and generic, using non-descriptive terms that don't convey specific information about what was actually fixed. Update the title to be more specific about the actual changes, such as 'fix: stabilize Select tests and update toast exports' or 'fix: replace act-based testing with user-event in Select tests'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-toast-export
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty self-assigned this Mar 17, 2026
@rohanchkrabrty rohanchkrabrty requested review from AkarshSatija, paanSinghCoder and rsbh and removed request for AkarshSatija March 17, 2026 10:15
@rohanchkrabrty rohanchkrabrty changed the title fix: stabilize Select tests fix: breaking build and tests Mar 17, 2026
@rohanchkrabrty rohanchkrabrty merged commit 1fa73b9 into main Mar 17, 2026
4 of 5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-toast-export branch March 17, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants