Open
Conversation
andrey-kazakov
commented
Jun 21, 2012
- incompatible encoding exception (US-ASCII vs ASCII-8BIT) was raised in Smpp::Pdu::Base#initialize while reading some PDUs from SMPP bytestream. it's fixed just by String#force_encoding to ASCII-8BIT.
- message_id was limited to be integer in Smpp::Tranciever#send_concat_mt. moreover, it's just ruined UDH structure if message_id was >255 and raised an exception if message_id was greater than unicode char range. it's fixed by using object_id of message_id (I don't think that internal ids must be integer anyway; I use hashes in my app, for example) and cutting it down to one octet ( & 0xFF).
…essage_id is not an integer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.