fix: make checkForCyclesAndMarkErrors a pure boolean detector#18
Open
Av1ralS1ngh wants to merge 1 commit intorawBit-io:mainfrom
Open
fix: make checkForCyclesAndMarkErrors a pure boolean detector#18Av1ralS1ngh wants to merge 1 commit intorawBit-io:mainfrom
Av1ralS1ngh wants to merge 1 commit intorawBit-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkForCyclesAndMarkErrors was mutating node.data.error and node.data.extendedError in-place on the input nodes, i.e. the same pattern fixed in #14 for annotateDirtyNodesWithError.
The mutation was also dead code: the only caller (useCalculation.ts) immediately discards the mutated affectedNodes and applies the error state itself via an immutable setNodes spread.
I removed the forEach mutation block from checkForCyclesAndMarkErrors. The function now purely returns a boolean.
Updated the unit test to assert the new contract: hasCycle is true and the input nodes are left untouched.