Open
Conversation
kalczur
suggested changes
Mar 31, 2026
| .table-of-contents { | ||
| padding: 0; | ||
| @apply p-0 overflow-y-auto; | ||
| max-height: calc(100vh - 110px - 4rem); |
Contributor
There was a problem hiding this comment.
Let's avoid magic numbers. Put it in a variable e.g. --toc-desktop-top: 110px;, then use it here and in a new class .toc-desktop.
Same for 4rem, but IDK where it belongs
|
|
||
| return ( | ||
| <div className="sticky top-[160px]"> | ||
| <div className="sticky top-[110px]"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <div className="sticky top-[110px]"> | |
| <div className="sticky toc-desktop"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDoc-3611
Additional description
Fixed scroll for sticky ToC
Type of change
/templatesor readme)Changes in docs URLs
/scripts/redirects.jsonfile, setDocuments MovedPR label)Changes in UX/UI