fix: add package_name input to cpp-post-build-check#529
Open
fix: add package_name input to cpp-post-build-check#529
package_name input to cpp-post-build-check#529Conversation
gforsyth
added
improvement
20 tasks
Contributor
Author
|
Tested in rapidsai/cudf@66b9e07 |
jameslamb
approved these changes
May 5, 2026
| CPP_DIR=$(rapids-download-from-github "$(rapids-artifact-name conda_cpp $PACKAGE_NAME "${REPO##*/}" --cuda)") | ||
| else | ||
| CPP_DIR=$(rapids-download-conda-from-github cpp) | ||
| fi |
Member
There was a problem hiding this comment.
Hopefully this is just temporary to allow the PR to be merged?
I'm fine with that. In general, I'd like to see there be as few different routes through the configuration as possible... e.g. I'd like the end state to be that package_name is required by all callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't know the post-build checks bake in a call to
rapids-package-nameviarapids-download-conda-from-github.rapids-artifact-namerequires explicit arguments for the package name, so I've added that as an input. If the argument isn't provided, we maintain the current behavior.