Exclude dependencies in pyproject.toml from verify-hardcoded-version
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardcoded-version
Member
Author
|
This was tested locally on cudf and worked |
jameslamb
approved these changes
Jan 23, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Noting that this came out of this discussion: rapidsai/cudf#21152 (comment)
I'd have liked to see a PR description and for it to have linked to that, so someone finding this from search in the future could understand why this change was made.
No comments about the implementation, looks good to me, let's ship it 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-dependency-file-generatorgenerates lists of dependencies inpyproject.toml. We want these lists to be excluded from the check, but still check other parts of the file, likeproject.version.Raised in rapidsai/cudf#21152 (comment)