Open
Conversation
cjnolet
reviewed
Mar 13, 2026
cpp/include/cuvs/distance/kde.hpp
Outdated
| */ | ||
| template <typename T> | ||
| void kde_score_samples(raft::resources const& handle, | ||
| const T* query, |
Member
There was a problem hiding this comment.
Can we accept mdspans here instead of raw pointers? That would also simplify the function signatures for the public APIs. Can still expose pointers at the cuml layer for now (for the python layer) if that's easier.
cjnolet
reviewed
Mar 13, 2026
cpp/include/cuvs/distance/kde.hpp
Outdated
| * @param[in] metric_arg Metric parameter (e.g. p for Minkowski; ignored otherwise) | ||
| */ | ||
| template <typename T> | ||
| void kde_score_samples(raft::resources const& handle, |
Member
There was a problem hiding this comment.
Would it make sense just call this "kde" or is there signficant enough post processing being done after calling this?
cjnolet
reviewed
Mar 13, 2026
cpp/include/cuvs/distance/kde.hpp
Outdated
| * These are the smoothing kernels used in KDE — distinct from the dot-product | ||
| * kernels (RBF, Polynomial, etc.) in cuvs::distance::kernels used by SVMs. | ||
| */ | ||
| enum class DensityKernelType : int { |
Member
There was a problem hiding this comment.
Can we at least consolidate this struct w/ the existing KernelType struct in distance.hpp?
aamijar
added
non-breaking
Member
|
/ok to test 4690f8d |
Member
|
@Intron7, thanks for the PR! |
Member
|
/ok to test 66d923b |
Member
|
/ok to test 8c852d5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cjnolet moved the kernel for KDE from cuml to cuvs. This PR is needed for rapidsai/cuml#7833