API for CPU side output indices and distances of all_neighbors#1905
Open
jinsolp wants to merge 4 commits intorapidsai:mainfrom
Open
API for CPU side output indices and distances of all_neighbors#1905jinsolp wants to merge 4 commits intorapidsai:mainfrom
all_neighbors#1905jinsolp wants to merge 4 commits intorapidsai:mainfrom
Conversation
aamijar
reviewed
Mar 12, 2026
| raft::make_device_vector_view<const T>(global_distances.data_handle(), num_rows * k)); | ||
| } | ||
|
|
||
| raft::resource::sync_stream(handle); |
Member
There was a problem hiding this comment.
Do we need a sync because we need to wait for GPU to finish some task?
Contributor
Author
|
@aamijar yes, so eventually all-neighbors will be further optimized for host side distances/indices! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1902
This PR allows indices/distances result of the
all_neighborsfunction to be on host memory. Focuses on exposing the API, and internally just does a copy.Internally, it still allocates GPU memory for the full indices/distances
n_clusters=1this is not a problem. If the user faces OOM issues they should usen_clusters>1.n_clusters>1we are still using managed memory regardless of the memory location of the user given indices/distances. Will open a follow-up PR with optimizations (related issue: [FEA] Improve batchedall-neighborsgiven CPU indices/distances #1903)