Prioritize SCA-required responses over generic init errors#216
Open
mo22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a response message contains both a generic not-yet-open-dialog 9xxx error, such as 9050, and a later 9075 response, the generic PIN/auth handling currently runs first. That blocks the PIN and raises FinTSClientPINError before the explicit strong-customer-authentication response is inspected.\n\nThis pre-scans the HIRMG/HIRMS response set while processing a message and lets the explicit 9075 handling take precedence over generic unopened-dialog 9xxx handling. Explicit PIN-related return codes still block the PIN as before.\n\nTested with:\n\n uv run --with pytest pytest tests/test_client.py::test_sca_required_takes_precedence_over_unopened_dialog_error\n uv run --with pytest pytest tests/test_client.py