Skip to content

[Meson] Only compile executables#46

Merged
jfowkes merged 1 commit into
masterfrom
prepare_major_release
Sep 14, 2025
Merged

[Meson] Only compile executables#46
jfowkes merged 1 commit into
masterfrom
prepare_major_release

Conversation

@amontoison
Copy link
Copy Markdown
Collaborator

We don't need a library libsifdecode.a in practice, let's directly generate the binary from the Fortran files.

@jfowkes
Copy link
Copy Markdown
Contributor

jfowkes commented Sep 14, 2025

Yeah I guess a library for sifdecoder is not required but probably best to check with @dpo and @nimgould to ensure this doesn’t break any existing use cases!

@amontoison
Copy link
Copy Markdown
Collaborator Author

@jfowkes For the Meson build system, we never used it for something else than building the binary sifdecoder.

@jfowkes
Copy link
Copy Markdown
Contributor

jfowkes commented Sep 14, 2025

I agree entirely but I noticed that on https://github.com/optimizers/homebrew-cutest there are instructions for linking in the sifdecoder library? I guess that’s how the make build system works…

@amontoison
Copy link
Copy Markdown
Collaborator Author

amontoison commented Sep 14, 2025

I propose these changes because we plan a release 3.0.0 and it is safe to do breaking changes now.
You already renamed sifdecoder_standalone into sifdecoder.

@jfowkes
Copy link
Copy Markdown
Contributor

jfowkes commented Sep 14, 2025

@amontoison okay agreed! Merged.

@jfowkes jfowkes merged commit 90858e4 into master Sep 14, 2025
29 checks passed
@jfowkes jfowkes deleted the prepare_major_release branch September 14, 2025 06:18
@nimgould
Copy link
Copy Markdown
Contributor

For the makefile builds, we have

% ar -t libsifdecode.a
sifdecode.o
sifdecoder_standalone.o
random.o
check_derivs.o

so, as you can see, the library contains more than just sifdecode. That is because the old sifdecoder has the ability to check generated derivatives, while that was not implemented for the standalone one as the checker needs to compile and link the generated element and group functions. But, I think we agreed that the meson build wasn't going to support all of the features that the makefile/script-based one does (it also misses select and classify).

@jfowkes
Copy link
Copy Markdown
Contributor

jfowkes commented Sep 14, 2025

Thanks @nimgould, yes @amontoison has already removed the check_derivs script and the select and classify scripts from the meson build as these are not implemented for the standalone sifdecoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants