refactor(cli): drop alloy-ethers-typecast for alloy Provider#122
Conversation
Replace ReadableClient / ReadContractParameters(Builder) with alloy Provider + eth_call (TransactionRequest + SolCall::abi_decode_returns), same pattern as the interpreter parser. Bump rain-erc git dep -> crates.io 0.1 (Provider-based supports_erc165). implements_i_described_by_meta_v1 is now generic over Provider; fetch_for_contract builds a provider from the first RPC. Tests use alloy connect_mocked_client instead of ReadableClient::new_mocked. Unblocks publishing the rain-metadata cli to crates.io. All 120 cli lib tests pass. Closes #121. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 42 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Removes the
alloy-ethers-typecastgit dependency from therain-metadatacli — the last blocker to publishing the cli to crates.io (#121).ReadableClient/ReadContractParameters(Builder)→ alloyProvider+eth_call(TransactionRequest+SolCall::abi_decode_returns), same pattern as the interpreter parser (rainlang#511).rain-ercgit dep → crates.io0.1(itssupports_erc165is nowProvider-based).implements_i_described_by_meta_v1is generic overProvider;fetch_for_contractbuilds a provider from the first RPC.connect_mocked_clientinstead ofReadableClient::new_mocked.All 120 cli lib tests pass; no
alloy_ethers_typecastreferences remain.Note:
fetch_for_contractnow reads from the first RPC rather than ReadableClient's multi-RPC fallback — fine for the cli; a fallback provider can be added later if needed.Closes #121.
🤖 Generated with Claude Code