Skip to content

Add deployment listing and sunset workflows#8

Merged
findolor merged 1 commit into
mainfrom
feature/deployment-id-ops
May 26, 2026
Merged

Add deployment listing and sunset workflows#8
findolor merged 1 commit into
mainfrom
feature/deployment-id-ops

Conversation

@findolor
Copy link
Copy Markdown
Collaborator

@findolor findolor commented May 23, 2026

Depends on

Motivation

Named deployments need basic operations after they are created: reviewers and operators should be able to see what is running, and old deployment instances should be easy to sunset after the web application has moved to a new manifest.

Solution

  • add a manual List Deployments workflow that reports deployment ID, timer status, service status, settings URL, service start time, next timer run, and work directory size
  • add a manual Sunset Deployment workflow that stops and disables one named deployment
  • keep deployment env, binary, and work state by default for rollback
  • add an explicit delete_state option for removing a deployment's host-side state
  • document deployment IDs, side-by-side operation, listing, and sunset behavior in README.md

Checks

By submitting this for review, I am confirming I have done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Validated locally with:

  • YAML parse for .github/workflows/deploy.yaml, .github/workflows/list-deployments.yaml, and .github/workflows/sunset-deployment.yaml
  • bash -n nixos/local-db-remote-run.sh
  • nix eval '.#nixosConfigurations.local-db-remote.config.systemd.timers."local-db-sync@".timerConfig.Unit'

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Warning

Review limit reached

@findolor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b9df114e-539e-4bf5-9300-4e4148b91233

📥 Commits

Reviewing files that changed from the base of the PR and between 7c057e8 and f83655b.

📒 Files selected for processing (3)
  • .github/workflows/list-deployments.yaml
  • .github/workflows/sunset-deployment.yaml
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/deployment-id-ops

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator Author

findolor commented May 23, 2026

@findolor findolor self-assigned this May 23, 2026
@findolor findolor changed the title feat: add deployment listing and sunset workflows Add deployment listing and sunset workflows May 23, 2026
@findolor findolor force-pushed the feature/deployment-id-deploy-workflow branch from 2eb7c17 to 65901bd Compare May 24, 2026 16:22
@findolor findolor force-pushed the feature/deployment-id-ops branch from 1b60148 to 492516c Compare May 24, 2026 16:22
@findolor findolor force-pushed the feature/deployment-id-deploy-workflow branch from 65901bd to 8d192bc Compare May 24, 2026 17:31
@findolor findolor force-pushed the feature/deployment-id-ops branch from 492516c to 1ceb02a Compare May 24, 2026 17:31
@findolor findolor force-pushed the feature/deployment-id-deploy-workflow branch from 8d192bc to eff0acb Compare May 26, 2026 08:05
@findolor findolor force-pushed the feature/deployment-id-ops branch from 1ceb02a to 5119815 Compare May 26, 2026 08:05
Copy link
Copy Markdown
Collaborator Author

findolor commented May 26, 2026

Merge activity

  • May 26, 3:00 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 3:06 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 3:06 PM UTC: @findolor merged this pull request with Graphite.

@findolor findolor changed the base branch from feature/deployment-id-deploy-workflow to graphite-base/8 May 26, 2026 15:03
@findolor findolor changed the base branch from graphite-base/8 to main May 26, 2026 15:04
@findolor findolor force-pushed the feature/deployment-id-ops branch from 5119815 to f83655b Compare May 26, 2026 15:05
@findolor findolor merged commit 129f5c2 into main May 26, 2026
1 check passed
findolor added a commit that referenced this pull request May 26, 2026
## Depends on

- #8
- rainlanguage/raindex#2587

## Motivation

We want to test the deployment-id local DB remote flow with the raindex changes from rainlanguage/raindex#2587 before deploying a named sync instance.

That upstream PR adds a `derived_trades` local DB read model and bumps the local DB schema to version 4. Testing it through this repository lets the remote deployment workflow build and install the CLI from the exact raindex commit that contains those schema changes.

## Solution

- bump `lib/raindex` from `9b33a3c4eca44726b4602f1a2d4046982584ef93` to `cce428bf874443f55280705d8d2da157ef9921ab`
- use the latest commit from rainlanguage/raindex#2587: `cce428bf874443f55280705d8d2da157ef9921ab`
- include the upstream derived-trades changes needed for the local DB schema version 4 deployment test

Relevant upstream raindex PR context:
- PR: rainlanguage/raindex#2587
- Title: Add derived trades local DB read model
- Branch: `arda/derived-trades-schema`
- Latest commit: `cce428bf874443f55280705d8d2da157ef9921ab`
- Main behavior: maintain `derived_trades` during local DB sync and read trade lists from that derived table

## Checks

By submitting this for review, I am confirming I have done the following:
- [x] made this PR as small as possible
- [ ] unit-tested any new functionality
- [x] linked any relevant issues or PRs
- [ ] included screenshots (if this involves a front-end change)

Validated locally with:
- `git submodule status lib/raindex`
- `git diff --stat feature/deployment-id-ops..HEAD`

Not run:
- no deploy was run from this branch
- no local raindex build was run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants