Skip to content

Conversation

@julioalucero
Copy link
Collaborator

@julioalucero julioalucero commented Oct 31, 2025

Improve Test Coverage

Summary

Improved test coverage across controllers, models, and services.

  • Some tests are basic, covering validations and basic objects.
  • Others use mocks for now, but establishes a foundation for maintaining and improving test coverage.

By doing this change we increase Coverage from 43.24%86.36%

Before

Screenshot 2025-10-31 at 5 23 11 pm

After

Screenshot 2025-10-31 at 5 22 39 pm

Fix Deprecation Warnings

Fixes two Rails 8.1 deprecation warnings:

  1. HTTP status code: Updated :unprocessable_entity:unprocessable_content Url: TBD maybe Rack status code name changes breaks HttpStatusMatcher rspec/rspec-rails#2763?
  2. Timezone handling: Added config.active_support.to_time_preserves_timezone = :zone URL: TBD, maybe app:update prints deprecation warnings during active_storage:update rails/rails#53558

@julioalucero julioalucero self-assigned this Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.35%. Comparing base (4697f35) to head (a6331aa).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #129       +/-   ##
===========================================
+ Coverage   62.69%   86.35%   +23.65%     
===========================================
  Files          48       48               
  Lines         689      689               
===========================================
+ Hits          432      595      +163     
+ Misses        257       94      -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julioalucero julioalucero force-pushed the increase-test-coverage branch from e79f602 to a6331aa Compare October 31, 2025 21:06
@julioalucero julioalucero marked this pull request as ready for review November 3, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants