Fix column sort issue when oldSortDisplay is empty#139
Open
brianfdrg wants to merge 1 commit into
Open
Conversation
Sorting would break after adding a column, sorting on it, and then removing it. currentSort still contained the removed column's data type, causing sortFields to include entries no longer in the DOM. Then oldSortDisplay would be empty, and error at line 954. After that clicking on column headers would do nothing. Added a check to skip sort fields that no longer map to a column header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting would break after adding a column, sorting on it, and then removing it. currentSort still contained the removed column's data type, causing sortFields to include entries no longer in the DOM. Then oldSortDisplay would be empty, and error at line 954. After that clicking on column headers would do nothing. Added a check to skip sort fields that no longer map to a column header.