Skip to content

removes fathom#78

Merged
ECWireless merged 1 commit into
mainfrom
remove-fathom
May 28, 2026
Merged

removes fathom#78
ECWireless merged 1 commit into
mainfrom
remove-fathom

Conversation

@skuhlmann
Copy link
Copy Markdown
Contributor

@skuhlmann skuhlmann commented May 28, 2026

Summary by CodeRabbit

  • Chores
    • Removed an external analytics library from project dependencies.
    • Refactored event tracking system across form submissions, email signups, and user interactions throughout the application.
    • Removed legacy analytics components and commented scripts from the codebase.
    • Updated event tracking to use a consolidated event identifier system for hiring forms, signups, and system features.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
website Ready Ready Preview, Comment May 28, 2026 3:38pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccf0d515-7336-4e5d-9116-4df92705ab44

📥 Commits

Reviewing files that changed from the base of the PR and between f25ea73 and e90f2be.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (9)
  • package.json
  • public/witch/index.html
  • src/app/layout.tsx
  • src/components/CohortHero.tsx
  • src/components/Fathom.tsx
  • src/components/HireUs.tsx
  • src/components/JoinUs.tsx
  • src/lib/analytics.ts
  • src/providers/providers.tsx
💤 Files with no reviewable changes (6)
  • src/components/Fathom.tsx
  • package.json
  • src/app/layout.tsx
  • public/witch/index.html
  • src/components/JoinUs.tsx
  • src/components/HireUs.tsx

📝 Walkthrough

Walkthrough

Analytics tracking migrates from fathom-client to Vercel's trackAnalyticsEvent. New event constants are added to the shared analytics module, Fathom infrastructure is removed from dependencies and layouts, and all component and provider tracking calls are refactored to emit structured events through the new system.

Changes

Analytics Migration from Fathom to Vercel

Layer / File(s) Summary
Expand analytics event definitions
src/lib/analytics.ts
Two new event identifiers added: cohortHeroEmailSignup for cohort hero email signups and witchTriggered for witch trigger activation.
Remove Fathom infrastructure
package.json, src/app/layout.tsx, public/witch/index.html
Fathom dependency is removed from package.json, the Fathom component import and render are deleted from RootLayout, and the commented Fathom analytics script is removed from the witch page HTML.
Migrate CohortHero analytics
src/components/CohortHero.tsx
Import switches from fathom-client to shared analytics module; successful email signup now calls trackAnalyticsEvent with cohortHeroEmailSignup and a hasReferral boolean.
Migrate JoinUs analytics
src/components/JoinUs.tsx
Fathom import is removed and the legacy trackEvent("join-us-submission") is replaced with trackAnalyticsEvent(analyticsEvents.joinSignupSuccess, { hasReferral }).
Migrate HireUs analytics
src/components/HireUs.tsx
Fathom import replaced with shared analytics; form submission and wizard step tracking now use trackAnalyticsEvent with event names like hireFormSubmitAttempt, hireFormSubmitSuccess, and hireFormStepCompleted, including budget and servicesCount properties.
Migrate witch trigger analytics
src/providers/providers.tsx
Fathom import replaced with shared analytics; both keyboard and click-pattern witch triggers now call trackAnalyticsEvent(analyticsEvents.witchTriggered) with a method property set to "keyboard" or "click_pattern".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • raid-guild/website#76: Implements the same analytics migration toward Vercel events in shared integration points like src/app/layout.tsx and form components.
  • raid-guild/website#49: Modifies src/providers/providers.tsx to track witch trigger events with fathom-client; this PR replaces that with the new Vercel tracking system.
  • raid-guild/website#51: Modifies Fathom wiring in components like HireUs.tsx and JoinUs.tsx; this PR completes the migration away from fathom-client.

Poem

🐰 Farewell to fathom, hello Vercel's way,
Analytics events now trackable each day,
With structured data flowing clean and bright,
The witch still triggers, with method in sight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing Fathom analytics throughout the codebase, including dependencies, components, and integrations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-fathom

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/CohortHero.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/lib/analytics.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

src/providers/providers.tsx

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Fathom analytics integration and standardizes all event tracking on the existing Vercel Analytics wrapper (trackAnalyticsEvent / analyticsEvents), cleaning up legacy scripts and dependencies in the process.

Changes:

  • Removed fathom-client from dependencies and deleted the Fathom component wiring from the app layout.
  • Replaced trackEvent(...) calls with trackAnalyticsEvent(...) and added consolidated event identifiers for cohort hero signup and the “witch” easter egg trigger.
  • Removed leftover/commented Fathom script references from static content.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/providers/providers.tsx Switches “witch” easter egg tracking from Fathom to Vercel analytics events/properties.
src/lib/analytics.ts Adds new consolidated event identifiers used by updated components.
src/components/JoinUs.tsx Removes Fathom tracking call; relies on existing Vercel analytics tracking.
src/components/HireUs.tsx Removes Fathom tracking calls; keeps Vercel analytics tracking for attempts/success/step completion.
src/components/Fathom.tsx Deletes the Fathom client component entirely.
src/components/CohortHero.tsx Replaces Fathom event with Vercel analytics event + properties.
src/app/layout.tsx Removes <Fathom /> usage; keeps Vercel analytics component mounted.
public/witch/index.html Removes commented Fathom script block.
package.json Drops fathom-client dependency.
bun.lock Updates lockfile to remove fathom-client (and includes lock metadata update).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ECWireless ECWireless merged commit 7c871ab into main May 28, 2026
4 checks passed
@ECWireless ECWireless deleted the remove-fathom branch May 28, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants