This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Focalpoint #19
Merged
Focalpoint #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready to merge. |
Open
Contributor
Author
|
Hey so this is ready to go but it's missing docs. Once we get through the rounds of pull requests we I think we should rewrite the docs. There needs to be a separate section for URL parameters. There will be more and more features that only have a URL parameter (like this one). |
Contributor
Author
|
ping |
Owner
|
Can you rebase off the current HEAD? The auto-orientation changes seem to be in here as well. |
Contributor
Author
|
ping |
halfshell/image.go
Outdated
Owner
There was a problem hiding this comment.
Shouldn't we return Focalpoint{0.5, 0.5} if either ParseFloat calls fail?
Owner
|
Sorry for the delay in looking at this. Just a couple minor comments. |
Contributor
Author
|
np, thanks for the feedback! |
Contributor
Author
|
ping |
Owner
|
LGTM. Sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: this PR is dependent on #17 and #20)