Skip to content

fix(lrt): scope skip-list update to install/upgrade only#11456

Merged
DariuszPorowski merged 7 commits intomainfrom
copilot/fix-radius-installation-script
Apr 5, 2026
Merged

fix(lrt): scope skip-list update to install/upgrade only#11456
DariuszPorowski merged 7 commits intomainfrom
copilot/fix-radius-installation-script

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

LRT on Azure was failing due to skip-delete-resources-list.txt being unconditionally overwritten every run regardless of whether install/upgrade occurred.

Changes

.github/scripts/manage-radius-installation.sh

  • Extract kubectl UCP resource snapshot into save_skip_resources_list() helper (with error handling); call it only in the install and upgrade branches — not the version-match no-op path

.github/workflows/long-running-azure.yaml

  • Remove the unconditional "Create a list of resources not to be deleted" step; the snapshot now lives inside manage-radius-installation.sh and is scoped to install/upgrade only

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Contributor checklist

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

…pshot to install/upgrade only

Co-authored-by: sk593 <42750942+sk593@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix long-running tests by reverting database setting and updating resources list Fix LRT Azure failures: revert database.enabled and scope skip-list update to install/upgrade only Mar 19, 2026
Copilot AI requested a review from sk593 March 19, 2026 17:53
Comment thread .github/workflows/long-running-azure.yaml
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.40%. Comparing base (1a6c587) to head (86af4fe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11456   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         699      699           
  Lines       44156    44156           
=======================================
  Hits        22698    22698           
  Misses      19291    19291           
  Partials     2167     2167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

Unit Tests

    2 files  ±0    415 suites  ±0   6m 51s ⏱️ +6s
4 872 tests ±0  4 870 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 774 runs  ±0  5 772 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 86af4fe. ± Comparison against base commit 1a6c587.

♻️ This comment has been updated with latest results.

@sk593 sk593 had a problem deploying to external-contributor-approval March 25, 2026 22:37 — with GitHub Actions Failure
@sk593 sk593 changed the title Fix LRT Azure failures: revert database.enabled and scope skip-list update to install/upgrade only Fix LRT Azure failures: scope skip-list update to install/upgrade only Mar 25, 2026
@sk593 sk593 marked this pull request as ready for review March 25, 2026 22:39
@sk593 sk593 requested review from a team as code owners March 25, 2026 22:39
Copilot AI review requested due to automatic review settings March 25, 2026 22:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Azure long-running test (LRT) failures by ensuring skip-delete-resources-list.txt is only refreshed when Radius is actually installed/upgraded, instead of being overwritten on every run.

Changes:

  • Move UCP resource snapshot generation into save_skip_resources_list() inside manage-radius-installation.sh.
  • Call the snapshot helper only on install/upgrade paths (not on the version-match no-op path).
  • Remove the unconditional workflow step that regenerated the skip list every run.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/long-running-azure.yaml Removes the always-run kubectl snapshot step; relies on the script to generate the skip list only when needed.
.github/scripts/manage-radius-installation.sh Adds save_skip_resources_list() helper and invokes it from install/upgrade branches.
Comments suppressed due to low confidence (1)

.github/workflows/long-running-azure.yaml:282

  • After removing the step that always generated skip-delete-resources-list.txt, this cache save step can run when the file was neither restored (cache miss) nor created (version-match no-op). actions/cache/save typically fails when the specified path doesn't exist, which would break the workflow even though skipping install/upgrade is a valid outcome. Guard this step with an if that checks the file exists (or create a minimal file in the no-op path without overwriting an existing one).
      - name: Save list of resources not to be deleted
        uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
        with:
          path: skip-delete-resources-list.txt
          key: skip-delete-resources-list-${{ steps.gen-id.outputs.UNIQUE_ID || github.run_id }}

Comment thread .github/scripts/manage-radius-installation.sh Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Shruthi Kumar <shruthikumar2401@gmail.com>
@sk593 sk593 requested a deployment to external-contributor-approval April 3, 2026 19:28 — with GitHub Actions Waiting
@sk593 sk593 requested a deployment to external-contributor-approval April 3, 2026 19:29 — with GitHub Actions Waiting
@DariuszPorowski DariuszPorowski temporarily deployed to external-contributor-approval April 5, 2026 17:59 — with GitHub Actions Inactive
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests Bot commented Apr 5, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 86af4fe
Unique ID funcdcb6540046
Image tag pr-funcdcb6540046
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdcb6540046
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdcb6540046
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcdcb6540046
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdcb6540046
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdcb6540046
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@DariuszPorowski DariuszPorowski changed the title Fix LRT Azure failures: scope skip-list update to install/upgrade only fix(lrt): scope skip-list update to install/upgrade only Apr 5, 2026
@DariuszPorowski DariuszPorowski merged commit 2ea450a into main Apr 5, 2026
57 checks passed
@DariuszPorowski DariuszPorowski deleted the copilot/fix-radius-installation-script branch April 5, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants