x11: Use the GLXFBConfig to set the visual of an OpenGL canvas#364
Open
lexi-lambda wants to merge 1 commit intoracket:masterfrom
Open
x11: Use the GLXFBConfig to set the visual of an OpenGL canvas#364lexi-lambda wants to merge 1 commit intoracket:masterfrom
lexi-lambda wants to merge 1 commit intoracket:masterfrom
Conversation
Without doing this, the visual will not necessarily match that required by GLX, which prevents certain features from working correctly, most notably multisampling.
lexi-lambda
force-pushed
the
x11-set-gl-canvas-visual
branch
from
9e8d7e7 to
92731f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when creating an OpenGL
canvas%under X11,racket/guidoes not properly arrange for the X window’sVisualto be the one GLX selects for a givenGLXFBConfig. Without doing this, GLX may silently fall back to a more limited config, which prevents certain features from working correctly (most notably multisampling). This PR fixes the issue by explicitly setting the GTK widget’s visual before it is realized, which ensures the X window’s visual will be initialized appropriately.