Open
Conversation
User can pass a list of known switches to prefer.
The python script is "beefed up" with extra capabilities and it now handles the transitioning of the node through the various stages, including configuring RAID, running inspection, etc. Logging and error handling is improved. Ability to cope with non-standard cabling is improved slightly - we used to rely completely on a cabling convention to determine which port should be used for PXE. We now detect that from the LLDP data reported by the BMC (when available - note that we have hardware where the LLDP feature does not work). This provides us with the chassis MAC address of the connected switch. Until we can find an easy way to look this up, we allow the user to pass one or more PXE switch MACs on the command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is somewhat of an opinionated move from a large, complex workflow
that calls lots of different python scripts to a minimal workflow that
executes one single script to take all required steps.
In theory there are benefits to the multiple workflow steps, but in
practice I don't think we really benefit from the hardcore argo
functionality, and the workflows are fragile, difficult to read, almost
impossible to test, inscrutable to troubleshoot. By contrast the
python script is easily maintainable.
The python script is "beefed up" with extra capabilities and it now
handles the transitioning of the node through the various stages,
including configuring RAID, running inspection, etc.
Logging and error handling is improved.
Ability to cope with non-standard cabling is improved slightly - we used
to rely completely on a cabling convention to determine which port
should be used for PXE. We now detect that from the LLDP data reported
by the BMC (when available - note that we have hardware where the LLDP
feature does not work). This provides us with the chassis MAC address
of the connected switch. Until we can find an easy way to look this up,
we allow the user to pass one or more PXE switch MACs on the command
line.