feat(nautobotop): determine the username from the supplied token#1905
Open
feat(nautobotop): determine the username from the supplied token#1905
Conversation
9b87f11 to
c6cbbde
Compare
Avoid an issue where the username supplied is different than the token the user is for by always looking up the user that the token belongs to for the queries. Purposefully did not run: - make manifests - make copy-crds-to-helm So that we have a transition period in removing the username.
c6cbbde to
5e5fc85
Compare
Contributor
|
I like the change but looks like it not yet ready to merge. Few things I noticed that response from Nautobot api is like this, it only exposing displayname and not the username Other concerns.
Sure I want to add this change, but there can some slightly better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an issue where the username supplied is different than the token
the user is for by always looking up the user that the token belongs to
for the queries.
Purposefully did not run:
So that we have a transition period in removing the username.