feat(ironic): make target_datetime optional for set_bmc_clock step#1904
Merged
haseebsyed12 merged 1 commit intomainfrom Apr 2, 2026
Merged
feat(ironic): make target_datetime optional for set_bmc_clock step#1904haseebsyed12 merged 1 commit intomainfrom
haseebsyed12 merged 1 commit intomainfrom
Conversation
Allow the ``set_bmc_clock`` management setup in the redfish interface to set the time to the conductor if the time is not explicitly provided. This makes it possible to call this step and get an accurate time. For Ironic to manage the BMC, the time must be inline with the conductor so this is a better reasonable default. This also makes it possible to use the ``set_bmc_clock`` in runbooks, as originally intended, because users cannot supply a time for the runbooks without this fix the runbook could only ever set the time to a fixed value which isn't useful. Closes-Bug: 2146355 Change-Id: I54ce06b7025f174946b957df2c6fc2bedff11c37 Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
haseebsyed12
changed the title
cardoe
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
set_bmc_clockmanagement setup in the redfish interface to set the time to the conductor if the time is not explicitly provided. This makes it possible to call this step and get an accurate time. For Ironic to manage the BMC, the time must be inline with the conductor so this is a better reasonable default. This also makes it possible to use theset_bmc_clockin runbooks, as originally intended, because users cannot supply a time for the runbooks without this fix the runbook could only ever set the time to a fixed value which isn't useful.Closes-Bug: 2146355
Change-Id: I54ce06b7025f174946b957df2c6fc2bedff11c37
Signed-off-by: Doug Goldstein cardoe@cardoe.com