Open
Conversation
I have noticed that some of our more complex CircleCI workflows had been suboptimal for various reasons. One of them was that in some cases we ended up building Lambda packages twice: once with the SAM build step, then during deploy if the Terraform Lambda module was used with certain parameters. The other issue was attaching the workspace to deploy jobs that were behind a manual hold step, because at that point every single job prior to the approval step became a parent of the subsequent deploy jobs, which meant that every single workspace was attached by CircleCI and that operation can be quite slow.
szilveszter
force-pushed
the
szilveszter/artifact-based-deploy
branch
from
bd248a6 to
35ffee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that some of our more complex CircleCI workflows had been suboptimal for various reasons.
One of them was that in some cases we ended up building Lambda packages twice: once with the SAM build step, then during deploy if the Terraform Lambda module was used with certain parameters.
The other issue was attaching the workspace to deploy jobs that were behind a manual hold step, because at that point every single job prior to the approval step became a parent of the subsequent deploy jobs, which meant that every single workspace was attached by CircleCI and that operation can be quite slow.