-
Notifications
You must be signed in to change notification settings - Fork 12
Added marketing slides #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gal42
wants to merge
27
commits into
rachelkang:main
Choose a base branch
from
gal42:MIAUI-Clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIAUI sample draft for reference. Started to work on adding new task. Has bugs with InitializeComponent method
No binding has been implemented yet, but previous bugs have been fixed.
This reverts commit 05da8cd.
MIAUI sample draft for reference. Started to work on adding new task. Has bugs with InitializeComponent method
No binding has been implemented yet, but previous bugs have been fixed.
Marketing slides for MIAUI, Azure AD, Azure B2C
rachelkang
reviewed
Aug 24, 2022
Owner
rachelkang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look awesome!!
A few small suggestions I have:
- For the Azure AD image, I believe there's a version of the app where the "Azure AD Authentication Sample" text is centered. I think using that would be better if you can make it happen! (It was with using HorizontalTextAlignment="Center")
- It would be cool to see screenshots of the full screen for all the screens so that the content doesn't get cut off (especially for the MIAUI one)
They look great the way they are though. Great work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketing slides for MIAUI, Azure AD, Azure B2C