feat(symbolizer): Always symbolize kernel callstack frame modules#666
Open
rabbitstack wants to merge 4 commits intomasterfrom
Open
feat(symbolizer): Always symbolize kernel callstack frame modules#666rabbitstack wants to merge 4 commits intomasterfrom
rabbitstack wants to merge 4 commits intomasterfrom
Conversation
The device path resolver is a remnant not utilized anymore, so it is safe to remove.
The main motivation to swithcing to NtQuerySystemInformation is to determine the memory range of the loaded module.
Enhance the callstack symbolizer to resolve kernel-mode addresses by leveraging loaded kernel driver information. When kernel driver metadata is available, the symbolizer maps raw kernel addresses to their corresponding module paths, improving trace readability and diagnostic accuracy for kernel call stacks. In this mode, the symbolizer consults the in-memory list of loaded kernel modules/drivers and uses their base addresses and image ranges to perform address-to-module resolution. This enables accurate attribution of kernel stack frames to their originating driver binaries rather than leaving them as unresolved or raw addresses, as it was the case when the kernel address symbolization is disabled (disabled by default) because DbgHelp handler registration would consume ~50MB just to load debug information.
rabbitstack
force-pushed
the
always-symbolize-kernel-callstack-frame-modules
branch
from
ae2343b to
49c3874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Enhance the callstack symbolizer to resolve kernel-mode addresses by leveraging loaded kernel driver information. When kernel driver metadata is available, the symbolizer maps raw kernel addresses to their corresponding module paths,
improving trace readability and diagnostic accuracy for kernel call stacks.
In this mode, the symbolizer consults the in-memory list of loaded kernel modules/drivers and uses their base addresses and image ranges to perform address-to-module resolution. This enables accurate attribution of kernel
stack frames to their originating driver binaries rather than leaving them as unresolved or raw addresses, as it was the case when the kernel address symbolization is disabled (disabled by default) because DbgHelp handler registration would consume ~50MB just to load debug information.
What type of change does this PR introduce?
/kind feature (non-breaking change which adds functionality)
/kind improvement
Any specific area of the project related to this PR?
/area instrumentation
Special notes for the reviewer
Does this PR introduce a user-facing change?