refactor(event): Introduce event decoder#665
Open
rabbitstack wants to merge 1 commit intomasterfrom
Open
Conversation
rabbitstack
force-pushed
the
refactor-event-param-decoding
branch
from
60e70c0 to
2991fa1
Compare
Add a dedicated parameter decoder responsible for extracting and interpreting event parameters from raw byte payloads. The decoder is designed with a modular approach where each method handles a specific type of event type or a group of events, enabling clearer separation of concerns and easier extensibility for future event formats. This refactor improves readability, maintainability, and correctness of event parsing logic, while making it easier to extend support for new event and parameter types in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Add a dedicated parameter decoder responsible for extracting and interpreting event parameters from raw byte payloads. The decoder is designed with a modular approach where each method handles a specific type of event type or a group of events, enabling clearer separation of concerns and easier extensibility for future event formats.
This refactor improves readability, maintainability, and correctness of event parsing logic, while making it easier to extend support for new event and parameter types in the future.
What type of change does this PR introduce?
/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)
/kind improvement
Any specific area of the project related to this PR?
/area telemetry
Special notes for the reviewer
Does this PR introduce a user-facing change?