Remove usage of ATTRIB()
#481
Open
+129
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroen
force-pushed
the
r-devel
branch
3 times, most recently
from
7d18fa6 to
dd32710
Compare
Member
Author
|
I don't understand this error. |
Since as of R 3.5, this is pretty efficient. It won't ever "fully expand" compact row names. The worst case is converting `c(NA, -n)` to an ALTREP compact intrange, which is still cheap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just merges the change that Luke made, but conditional on the R version.
This should fix the mess that CRAN created by publishing the package that only works on R-devel.