Conversation
Collaborator
Author
|
It does not take effect on the iOS settings page. Will solve it in the future. |
Collaborator
Author
|
There are some upstream bugs that are known to exist in different system versions, for example:
These should not be considered implementation issues for this extension and can only wait for upstream fixes. |
Collaborator
Author
|
Since the current settings changes are persisted async and do not await for completion, if the user closes the page too quickly, the settings may not be persisted, although this is usually not happens. But later refactoring should probably add indicators and await for persistence to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve