feat: add staging ECR deployment action for dev builds#6
Open
drernie wants to merge 7 commits into
Open
Conversation
Add reusable GitHub Action for deploying Lambda images to staging ECR. This enables developers to build and test dev images without touching production infrastructure. Key features: - Deploys to staging account (712023778557) - Supports custom image tags (e.g., dev-feature-v1) - Single region deployment (us-east-1) by default - Auto-creates ECR repository if needed - OIDC authentication with GitHub Actions Related to tabulator dev workflow improvements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
✅ Infrastructure Deployed SuccessfullyThe IAM infrastructure required for this action has been deployed to the staging account. Deployed ResourcesCloudFormation Stack:
Status
Next StepsThis action is now ready to use! Once this PR is merged, the tabulator dev workflow can use it with: - uses: quiltdata/gh-actions/lambda-deploy-ecr-staging@main
with:
dockerfile-path: Dockerfile
docker-context-path: .
name: tabulator
image-tag: ${{ steps.tag.outputs.tag_name }}The workflow will authenticate using the deployed IAM role and push images to staging ECR. Related
🤖 Infrastructure deployed and verified |
New push-deployment action: - Finds PR by branch name in source repository - Extracts deploy:<branch> label to determine target - Updates versions.csv in deployment repository - Direct push to target branch (no PR creation) - Comprehensive error handling and validation - Detailed README with examples Lambda deploy action improvements: - Fix role name capitalization (tabulator -> Tabulator) - Ensures proper IAM role name format - Maintains compatibility with existing deployments The push-deployment action enables automatic deployment updates when dev tags are pushed, routing to the correct environment based on PR labels. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Use printf with -F flag for multi-line commit messages instead of heredoc syntax which was causing YAML parser errors. This resolves the "Unrecognized named-value: 'inputs'" error by using environment variables properly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The deployment repository stores versions.csv at t4/template/environment/versions.csv, not in the root directory. This was causing the push-deployment action to fail with "versions.csv not found in deployment repository". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add GitHub Actions cache support to both ECR deployment actions: - lambda-deploy-ecr-staging: Added --cache-from/--cache-to flags - lambda-deploy-ecr: Added --cache-from/--cache-to flags This enables BuildKit to cache Docker layers between workflow runs, significantly reducing build times when only source code changes (dependencies remain cached). Works in conjunction with multi-stage Dockerfile optimizations from docker-layer-caching branch. Related: quiltdata/tabulator#107 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The file is located at t4/template/environment/versions.csv, not versions.csv in the repo root. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The previous sed command was replacing the entire row with just component,version which destroyed the other 6 CSV fields. Changes: - Use awk instead of sed to update only the version field (column 2) - Preserve all other fields: ecr_account, ecr_region, ecr_prefix, ecr_repo, stage, notes - Works correctly when multiple rows have same component name (e.g., tabulator prod vs dev) This fixes the issue where updating tabulator would result in: tabulator,dev-xyz instead of: tabulator,dev-xyz,712023778557,us-east-1,,,dev,Dev deployment... 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
maybe we need only to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable GitHub Action for deploying Lambda images to staging ECR, enabling developers to build and test dev images without touching production infrastructure.
Changes
lambda-deploy-ecr-staging/action.yaml- Composite action definition with inputs for image taggingupload_ecr_staging.sh- Script to push images to staging ECRKey Features
dev-feature-v1,dev-bugfix-123)lambda-deploy-ecractionUsage Example
Test Plan
Related
infra-templatesrepodev.ymlworkflow🤖 Generated with Claude Code