Skip to content

refactor list splits pagination, env var to skip initial seeding#6385

Open
mattmkim wants to merge 1 commit intomainfrom
matthew.kim/byoc-metrics-fixes
Open

refactor list splits pagination, env var to skip initial seeding#6385
mattmkim wants to merge 1 commit intomainfrom
matthew.kim/byoc-metrics-fixes

Conversation

@mattmkim
Copy link
Copy Markdown
Contributor

@mattmkim mattmkim commented May 5, 2026

Description

  • we were paginating list metrics/sketch splits with 3 different implementations, puts it in one place
  • adds env var to skip intial seeding/fetching of immature splits on startup. TODO is to rewrite the query to only fetch splits we should care about (given some node_id, within the maturity period)

How was this PR tested?

Describe how you tested this PR.

@mattmkim mattmkim marked this pull request as ready for review May 5, 2026 20:20
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/quickwit-oss/quickwit/blob/8a348274c5409a6aaf0804a2d630208a31ac4685/quickwit-indexing/src/actors/metrics_pipeline/mod.rs#L15-L20
P1 Badge Restore the metrics pipeline module declarations

This file now declares metastore submodules such as file_backed, index_metadata, and control_plane_metastore, but the quickwit-indexing/src/actors/metrics_pipeline directory only contains the Parquet pipeline files (parquet_doc_processor.rs, pipeline.rs, etc.; I checked the directory and searched for pub mod file_backed). As soon as the metrics pipeline module is compiled, Rust will look for missing files like metrics_pipeline/file_backed.rs while the real pipeline submodules and re-exports were removed, so metrics indexing cannot build or expose ParquetMergePipeline, MetricsPipeline, and related actors.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@g-talbot g-talbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look super deeply but this seems like a worthwhile refactor.

@mattmkim mattmkim force-pushed the matthew.kim/byoc-metrics-fixes branch from 8a34827 to 32ecc52 Compare May 6, 2026 03:13
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32ecc52f5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

//! ```

mod indexing_service_impl;
mod parquet_compaction_metrics;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the declared compaction metrics module

In the reviewed commit, this new module declaration has no corresponding parquet_compaction_metrics.rs or parquet_compaction_metrics/mod.rs under quickwit-indexing/src/actors/metrics_pipeline (rg --files quickwit/quickwit-indexing/src/actors/metrics_pipeline | rg parquet_compaction_metrics returns nothing). Any build that includes quickwit-indexing will fail with Rust's missing-module error before reaching the pagination changes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants