pipewire: write route volumes without volume step#808
Open
faithleysath wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PipeWire route volume writes for devices that do not report
SPA_PROP_volumeStep.On these devices,
volumeStepis parsed as-1. The previous logic only calledPwDevice::setVolumes(...)from inside thevolumeStep != -1branch, so route-backed sink volume writes updated Quickshell's localmVolumesstate but did not write the new volume to PipeWire.This keeps the existing minimum-step filtering when a device reports
volumeStep, and treats a missing step value as "no step threshold", allowing the route volume write to proceed.Fixes #807
Testing
just configure debug -DNO_PCH=ON -DBUILD_TESTING=ONjust buildgit diff --checkbluez_output.6C_5A_B5_EB_5E_8D.1) by writingPipewire.defaultAudioSink.audio.volumes = [0.24, 0.24]from QML and verifyingwpctl get-volume @DEFAULT_AUDIO_SINK@changed toVolume: 0.24.just lint-changedwas not run because this local checkout does not have the requiredTIDYFOXenvironment variable configured.