core/desktopentry: add support for xdg-terminal-exec#638
Open
RGBCube wants to merge 3 commits intoquickshell-mirror:masterfrom
Open
core/desktopentry: add support for xdg-terminal-exec#638RGBCube wants to merge 3 commits intoquickshell-mirror:masterfrom
RGBCube wants to merge 3 commits intoquickshell-mirror:masterfrom
Conversation
RGBCube
force-pushed
the
xdg-terminal-exec
branch
from
f3f49f2 to
6095d01
Compare
RGBCube
changed the title
outfoxxed
force-pushed
the
master
branch
4 times, most recently
from
ca90821 to
3cf65af
Compare
RGBCube
force-pushed
the
xdg-terminal-exec
branch
11 times, most recently
from
9fd782a to
b9680c5
Compare
…nal=true desktopentries
RGBCube
force-pushed
the
xdg-terminal-exec
branch
from
b9680c5 to
7e42060
Compare
previously, we defaulted to /usr/local/share:/usr/share if the key was not set the standard tells you do default if the key is not set _or is empty_ this fixes that
RGBCube
force-pushed
the
xdg-terminal-exec
branch
from
7e42060 to
9968672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for executing
Terminal=truedesktop entries withDesktopEntry.execute()by readingxdg-terminals.listand scanning for terminals with TerminalEmulator in their categories and valid [X-]TerminalArg* attributes set.Also adds support for
OnlyShowIn,NotShowIn,TryExecto matchxdg-terminal-exec's total behaviour.Another thing fixed in this PR is the usage of XDG_DATA_DIR, the spec says that an empty value should still default to the usr paths. This makes the code respect that.