ParseGroup: Body field after nested repeating group#756
Open
agmt wants to merge 2 commits intoquickfixgo:mainfrom
Open
ParseGroup: Body field after nested repeating group#756agmt wants to merge 2 commits intoquickfixgo:mainfrom
agmt wants to merge 2 commits intoquickfixgo:mainfrom
Conversation
agmt
force-pushed
the
body-field-after-nested-repeating-group
branch
from
63e5cd6 to
57fef4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseGroupused to absorb any field after a nested group into the parent.It should only do so when the parent's template actually owns the tag. Otherwise the field belongs to the body.
Commits are split for review: the first adds a failing test, the second contains the fix.