-
Notifications
You must be signed in to change notification settings - Fork 658
Replace deprecated TLS cipher suite in SSLCertificateTest
#1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_128_GCM_SHA256 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…ES constant Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
SSLCertificateTest
|
@copilot this does not look good, errors are the same. Please have a look. |
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Fixed in commit 2f524f9. The issue was that ALL Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
SSLCertificateTestfails on newer JDKs becauseTLS_RSA_WITH_AES_128_CBC_SHAis deprecated per IETF draft-ietf-tls-deprecate-obsolete-kex.Changes
TLS_RSA_WITH_AES_128_CBC_SHAwithTLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256in parameterized test configurationTLS_RSA_WITH_AES_128_CBC_SHAandTLS_RSA_WITH_AES_256_CBC_SHAfromCERTIFICATE_REQUIRED_CIPHER_SUITESconstantThe replacement cipher suite provides forward secrecy via ECDHE (Elliptic Curve Diffie-Hellman Ephemeral) key exchange and modern AES-GCM authenticated encryption while maintaining TLSv1.2 compatibility. This addresses the IETF deprecation of ALL cipher suites using static RSA key exchange (all
TLS_RSA_*suites), not just CBC mode.Original prompt
SSLCertificateTestfails with newer JDKs</issue_title><issue_description>This is most probably due to the deprecation of cipher suite
TLS_RSA_WITH_AES_128_CBC_SHAwhich is used in this test.See https://datatracker.ietf.org/doc/draft-ietf-tls-deprecate-obsolete-kex/
We should use an alternative cipher suite which is not deprecated.
</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
SSLCertificateTestfails with newer JDKs #1120✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.