Skip to content

feat: share links to the queries using editor dropdown and shortcuts #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emrberk wants to merge 2 commits into
base: main
Choose a base branch
from
+807 −105
Open

feat: share links to the queries using editor dropdown and shortcuts #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f797d8
feat: share links to the queries using editor dropdown and shortcuts
emrberk May 25, 2026
517ebe5
update .gitleaksignore
emrberk May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitleaksignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
8f797d824d664ccecaf1ce356509db5a3e3b739d:e2e/tests/enterprise/oidc.spec.js:generic-api-key:174
8f797d824d664ccecaf1ce356509db5a3e3b739d:e2e/tests/enterprise/oidc.spec.js:generic-api-key:175
8f797d824d664ccecaf1ce356509db5a3e3b739d:e2e/tests/enterprise/oidc.spec.js:generic-api-key:176
35 changes: 24 additions & 11 deletions e2e/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,32 @@ const viewSchemas = {
"CREATE VIEW IF NOT EXISTS btc_trades_view AS SELECT * FROM btc_trades;",
}

before(() => {
Cypress.on("uncaught:exception", (err) => {
// this error can be safely ignored
if (err.message.includes("ResizeObserver loop")) {
return false
}
// Monaco editor's word highlighter throws "Canceled" errors during rapid tab switching
// when restoreViewState cancels pending async operations - this is harmless
if (err.message.includes("Canceled")) {
return false
Cypress.on("uncaught:exception", (err) => {
// Monaco editor's word highlighter throws "Canceled" errors during rapid tab switching
// when restoreViewState cancels pending async operations - this is harmless
if (err.message.includes("Canceled")) {
return false
}
})

Cypress.on("window:before:load", (win) => {
const OriginalRO = win.ResizeObserver
win.ResizeObserver = class extends OriginalRO {
constructor(cb) {
super((entries, observer) => {
win.requestAnimationFrame(() => {
try {
cb(entries, observer)
} catch {
/* swallow callback errors */
}
})
})
}
})
}
})

before(() => {
indexedDB.deleteDatabase("web-console")
})

Expand Down
2 changes: 1 addition & 1 deletion e2e/questdb
Open in desktop
Submodule questdb updated 413 files
201 changes: 201 additions & 0 deletions e2e/tests/console/editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,207 @@ describe("&query URL param", () => {
.should("be.visible")
.should("have.attr", "active")
})

it("should lock editor and show confirmation dialog for DML mixed with SELECT, then run on confirm", () => {
// Given
const tableName = "share_link_a1"
cy.execQuery(`DROP TABLE IF EXISTS ${tableName}`)
cy.execQuery(`CREATE TABLE ${tableName} (val INT)`)
cy.execQuery(`INSERT INTO ${tableName} VALUES (1)`)
cy.intercept("/api/v1/sql/validate*", {
delay: 1500,
body: { queryType: "UPDATE" },
}).as("validate")
const query = `UPDATE ${tableName} SET val=999; SELECT val FROM ${tableName}`

// When
cy.visit(`${baseUrl}?query=${encodeURIComponent(query)}&executeQuery=true`)

// Then
cy.getByDataHook("editor-tabs-disabled").should("be.visible")
cy.window().then((win) => {
expect(win.monaco.editor.getEditors()[0].getRawOptions().readOnly).to.eq(
true,
)
})
cy.getByDataHook("success-notification").should("not.exist")

// When
cy.getByDataHook("share-link-confirmation-dialog").should("be.visible")

// Then
cy.getByDataHook("editor-tabs").should("be.visible")
cy.window().then((win) => {
expect(win.monaco.editor.getEditors()[0].getRawOptions().readOnly).to.eq(
false,
)
})

// When
cy.getByDataHook("share-link-confirmation-confirm").click()

// Then
cy.getByDataHook("success-notification")
.invoke("text")
.should(
"match",
/Running completed in \d+ms with\s+2 successful\s+queries/,
)
cy.execQuery(`DROP TABLE ${tableName}`)
})

it("should lock editor and show confirmation dialog for DDL mixed with SELECT, then NOT run on cancel", () => {
// Given
const tableName = "share_link_a2"
cy.execQuery(`DROP TABLE IF EXISTS ${tableName}`)
cy.execQuery(`CREATE TABLE ${tableName} (val INT)`)
cy.intercept("/api/v1/sql/validate*", {
delay: 1500,
body: { queryType: "DROP" },
}).as("validate")
const query = `DROP TABLE ${tableName}; SELECT 1`

// When
cy.visit(`${baseUrl}?query=${encodeURIComponent(query)}&executeQuery=true`)

// Then
cy.getByDataHook("editor-tabs-disabled").should("be.visible")
cy.window().then((win) => {
expect(win.monaco.editor.getEditors()[0].getRawOptions().readOnly).to.eq(
true,
)
})

// When
cy.getByDataHook("share-link-confirmation-dialog").should("be.visible")

// Then
cy.getByDataHook("editor-tabs").should("be.visible")
cy.window().then((win) => {
expect(win.monaco.editor.getEditors()[0].getRawOptions().readOnly).to.eq(
false,
)
})

// When
cy.getByDataHook("share-link-confirmation-cancel").click()

// Then
cy.getByDataHook("share-link-confirmation-dialog").should("not.exist")
cy.getByDataHook("success-notification").should("not.exist")
cy.execQuery(`SELECT * FROM ${tableName}`)
cy.execQuery(`DROP TABLE ${tableName}`)
})

it("should auto-run multiple SELECT statements without confirmation", () => {
// Given
const query = "SELECT 1; SELECT 2"

// When
cy.visit(`${baseUrl}?query=${encodeURIComponent(query)}&executeQuery=true`)

// Then
cy.getByDataHook("success-notification")
.invoke("text")
.should(
"match",
/Running completed in \d+ms with\s+2 successful\s+queries/,
)
cy.getByDataHook("share-link-confirmation-dialog").should("not.exist")
})

it("should drop standalone executeQuery param and not auto-run buffer contents", () => {
// Given
const tableName = "share_link_c11"
cy.execQuery(`DROP TABLE IF EXISTS ${tableName}`)
cy.execQuery(`CREATE TABLE ${tableName} (val INT)`)
cy.getEditorContent().should("be.visible")
cy.typeQueryDirectly(`DROP TABLE ${tableName}`)
cy.getCursorQueryGlyph().should("be.visible")
cy.wait(1000)

// When
cy.visit(`${baseUrl}?executeQuery=true`)

// Then
cy.getEditor().should("be.visible")
cy.location("search").should("not.contain", "executeQuery")
cy.getByDataHook("share-link-confirmation-dialog").should("not.exist")
cy.getByDataHook("success-notification").should("not.exist")
cy.execQuery(`SELECT * FROM ${tableName}`)
cy.execQuery(`DROP TABLE ${tableName}`)
})

it("should copy share-link URL from glyph dropdown, Alt+L, and Alt+Shift+L", () => {
if (!Cypress.isBrowser("electron")) return

// Given
cy.getEditorContent().should("be.visible")
cy.typeQueryDirectly("SELECT 1;\nSELECT 2;\nSELECT 3;")
cy.getCursorQueryGlyph().should("be.visible")
const expectedUrl = (sql) => {
const params = new URLSearchParams()
params.set("query", sql)
params.set("executeQuery", "true")
return `${baseUrl}/?${params.toString()}`
}

// When — glyph dropdown copies single full query
cy.openRunDropdownInLine(1)
cy.getByDataHook("dropdown-item-copy-query-link").click()

// Then
cy.window()
.its("navigator.clipboard")
.then((clip) => clip.readText())
.should("eq", expectedUrl("SELECT 1"))

// When — glyph dropdown copies a selection inside a single query
cy.selectRange({ lineNumber: 2, column: 1 }, { lineNumber: 2, column: 7 })
cy.getByDataHook("button-run-query").should("contain", "Run selected query")
cy.openRunDropdownInLine(2)
cy.getByDataHook("dropdown-item-copy-query-link").click()

// Then
cy.window()
.its("navigator.clipboard")
.then((clip) => clip.readText())
.should("eq", expectedUrl("SELECT"))

// When — Alt+L copies single query at cursor
cy.clickLine(3)
cy.getEditor().realClick()
cy.realPress(["Alt", "L"])

// Then
cy.window()
.its("navigator.clipboard")
.then((clip) => clip.readText())
.should("eq", expectedUrl("SELECT 3"))

// When — Alt+L copies selection spanning multiple queries
cy.selectRange({ lineNumber: 1, column: 1 }, { lineNumber: 2, column: 9 })
cy.getByDataHook("button-run-query").should(
"contain",
"Run 2 selected queries",
)
cy.realPress(["Alt", "L"])

// Then
cy.window()
.its("navigator.clipboard")
.then((clip) => clip.readText())
.should("eq", expectedUrl("SELECT 1;\n\nSELECT 2"))

// When — Alt+Shift+L copies all queries in tab
cy.realPress(["Alt", "Shift", "L"])

// Then
cy.window()
.its("navigator.clipboard")
.then((clip) => clip.readText())
.should("eq", expectedUrl("SELECT 1;\n\nSELECT 2;\n\nSELECT 3"))
})
})

describe("autocomplete", () => {
Expand Down
40 changes: 40 additions & 0 deletions e2e/tests/enterprise/oidc.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,46 @@ describe("OIDC", () => {
})
})

it("should preserve query and executeQuery params across OIDC redirect and show share-link confirmation dialog", () => {
// Given
const query =
"DROP TABLE IF EXISTS share_link_oidc_a; DROP TABLE IF EXISTS share_link_oidc_b"
interceptAuthorizationCodeRequest(`${baseUrl}?code=abcdefgh`)
interceptTokenRequest({
access_token: "gslpJtzmmi6RwaPSx0dYGD4tEkom",
Comment thread
emrberk marked this conversation as resolved.
refresh_token: "FUuAAqMp6LSTKmkUd5uZuodhiE4Kr6M7Eyv",
Comment thread
emrberk marked this conversation as resolved.
id_token: "eyJhbGciOiJSUzI1NiIsImtpZCI6I",
Comment thread
emrberk marked this conversation as resolved.
token_type: "Bearer",
expires_in: 300,
})

// When
cy.visit(
`${baseUrl}?query=${encodeURIComponent(query)}&executeQuery=true`,
)
cy.getByDataHook("auth-login").should("be.visible")
cy.getByDataHook("button-sso-login").click()
cy.wait("@authorizationCode")
cy.wait("@tokens")

// Then
cy.getEditor().should("be.visible")
cy.getByDataHook("share-link-confirmation-dialog").should("be.visible")

// When
cy.getByDataHook("share-link-confirmation-confirm").click()

// Then
cy.getByDataHook("success-notification")
.invoke("text")
.should(
"match",
/Running completed in \d+ms with\s+2 successful\s+queries/,
)

cy.logout()
})

it("display import panel", () => {
interceptAuthorizationCodeRequest(`${baseUrl}?code=abcdefgh`)
interceptTokenRequest({
Expand Down
Loading
Loading