Make it compile with MicroHs. #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustss
force-pushed
the
master
branch
2 times, most recently
from
361619a to
ab67048
Compare
sjakobi
reviewed
Dec 6, 2025
Comment on lines
+93
to
+94
| if impl(mhs) | ||
| cpp-options: -DFOLDABLE_TRAVERSABLE_IN_PRELUDE=0 |
Collaborator
There was a problem hiding this comment.
I don't quite understand why this is necessary. Doesn't your modification of misc/version-compatibility-macros.h ensure that this variable is set correctly?!
Author
There was a problem hiding this comment.
I think you're right. I'll fix it tomorrow.
Author
There was a problem hiding this comment.
I think you're right. I'll fix it tomorrow.
konsumlamm
reviewed
Dec 30, 2025
Comment on lines
+20
to
+23
| - name: make and install mhs | ||
| run: | | ||
| cd mhs | ||
| make minstall |
There was a problem hiding this comment.
Suggested change
| - name: make and install mhs | |
| run: | | |
| cd mhs | |
| make minstall | |
| - name: make and install mhs | |
| run: | | |
| cd mhs | |
| make minstall | |
| echo "$HOME/.mcabal/bin" >> "$GITHUB_PATH" |
This way, we can avoid having to do PATH="$HOME/.mcabal/bin:$PATH" every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.