Update SC Pulse#896
Open
N-010 wants to merge 83 commits into
Open
Conversation
…reserve and don’t consume reseed budget with tier top-ups on k4 rounds - test/contract_qtf.cpp: expose private/protected internals for unit tests, add exact-match k2/k3 ticket generators (unique), fund jackpot balance in k4 test, and force FR off in baseline k2/k3 revenue-split test
…eserve top-ups; correct schedule bitmask in specx
Auto-update QTF index in QRP Adds cleanup for allowedSmartContracts in QRP
…er and update related logic for consistency
…ticket initialization
Fixes padding
…ture/2026-01-12-Pulse # Conflicts: # src/contract_core/contract_def.h # src/contracts/Pulse.h # test/contract_pulse.cpp
…undState; introduce new functions for ticket, prize, and round handling; update tests accordingly.
…ut structure, and introduce ticket clamping logic.
…AutoDeposits`. Update `GetAutoStats` test for expanded participant roster and shared state verification.
…layer` input parameter for clarity and consistency.
…re consistency across definitions and contract handling.
…able consistency.
…ocator to Pulse wallet with validation and testing.
…12-Pulse # Conflicts: # src/contracts/Pulse.h
…uce `returnInvocatorReward` utility, and refactor reward logic across procedures for consistency and improved readability.
…ulse.h` for improved clarity and maintainability.
…12-Pulse # Conflicts: # src/contracts/Pulse.h
Franziska-Mueller
requested review from
Franziska-Mueller and
cyber-pc
and removed request for
cyber-pc
Franziska-Mueller
requested changes
May 26, 2026
| return __transfer(destination, amount, TransferType::qpiTransfer); | ||
| } | ||
|
|
||
| sint64 QPI::QpiContextProcedureCall::returnInvocatorReward() const |
Collaborator
There was a problem hiding this comment.
please remove this from qpi. qpi is not for mere code simplifications.
| * @note The current QX transfer fee is paid from the Pulse contract balance; any invocation reward is refunded. | ||
| */ | ||
| PUBLIC_PROCEDURE_WITH_LOCALS(TransferTokenToQx) | ||
| * @brief Releases PULSE share management rights to another contract for the invocator. |
Collaborator
There was a problem hiding this comment.
I think the description and the name of the procedure is a bit misleading because you are not transferring Pulse shares but QHeart tokens.
Contributor
Author
There was a problem hiding this comment.
Thank you. I fixed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest adding a
returnInvocatorRewardfunction toQPIExpanding the function from transferring asset control rights to
QXto transferring to anySC