New version of Nostromo#842
Draft
N-010 wants to merge 43 commits into
Draft
Conversation
…functionality, including participant management, lot handling, and visibility settings.
… auction parameter resolution, lot asset management, and data validation into reusable private functions.
…simplify auction initialization, modularize parameter resolution, and enforce duration cap validation.
… IPFS CID validation with character checks and integration into `CreateAuction` function.
…Nostromo`: enhance `resolveBatchAuctionCreateParams` and `resolveStandardAuctionCreateParams` with price-related inputs and validation logic.
…tromo`: ensure `salePricePerUnit` is non-zero and less than or equal to `initialPricePerUnit`.
…idder validation, and refine access asset checks for private auctions.
…elAuction` procedure with fee logic, participant refunds, and state updates; refactor auction fields to use total prices instead of per-unit pricing.
…ltiple required assets, add validation functions, and refactor private auction checks.
…flags with `uint8`, enhance access validation with `hasAccess`, and refine checks for required access assets and allowed wallets.
…and `ProcessStandardBid` procedures, refactor `PlaceBid` for auction-type-specific bid handling, and encapsulate participant and auction updates.
… clarity with detailed field descriptions, standardize comment format, and improve internal documentation consistency.
…icing in auctions, remove redundant bidder and escrow fields, refine bid processing procedures, and enhance refund and validation logic.
…rollback: refine `@brief` documentation for price fields, standardize comment formatting, and invoke `participants.cleanupIfNeeded()` during rollback.
…nt new participants if storage is full and return `StorageFull` error code.
…ntroduce post-epoch auction pause mechanism, tick-based scheduling for auction finalization, and new procedures for batch and standard auction finalization.
…nts for clarity, remove unused checks in input validation, and simplify auction setup logic.
…implement `DistributeAuctionRevenue` for fee allocation, introduce `ResolvePendingStandardAuction` for seller decisions, and refine auction finalization procedures to support revenue sharing logic.
…r auction procedures, refine field documentation, and introduce detailed `@brief` comments for clarity and consistency.
…ic with `switch` statement and improve inline documentation for batch auction finalization procedures.
…ment `RecomputeBatchHighestBid` procedure, update bid processing to trigger recomputation when needed, and introduce supporting data structures and logic.
…t fee constants, enable runtime fee updates via new procedures `SetAuctionFees`, `
… expose current fee configuration and recipient wallets via structured input/output, register new user functions.
…esting logic, consolidate helper functions, and introduce `ContractTestingNostromoAuctionFromScratch` class for auction-related test cases.
…imer pause intervals, synchronize deadlines with pause states, and add test cases for deadline adjustments.
…ingNOST`: simplify test class structure, introduce `NOSTChecker` for state interactions, and streamline auction-related helper functions.
… accurate timer adjustments, align deadlines with current pause state, and refactor balance-checking logic in tests to improve test accuracy.
…d shareholder dividend pool changes and replace direct comparisons with computed expectations. Update relevant assertions for accuracy.
…rray<AuctionData, 1>` to support consistent handling of auction data, update all related method calls and tests.
N-010
added a commit
to N-010/qubic-contract-verify
that referenced
this pull request
Apr 17, 2026
…uctionData`, update method calls and tests accordingly.
…n logic, and integrate with private auction and cancellation flows. Update related tests and constants.
… implement safer flow with validation checks, and ensure proper invocation reward handling and refund logic.
…fields, separate persistent state (`AuctionData`) and ABI views (`AuctionView`), and update all references and logic to use the new structure.
…ds with `AuctionCore` references, update related assertions, and introduce `seedUser` to streamline user initialization logic.
…dd `placeBidWithFundedReward`, extend `transferManagedShares` with reward options, integrate private auction access lists, and ensure proper handling for scenarios like storage full conditions. Update tests accordingly.
Collaborator
…ture/upgrade-nostromo
Contributor
Author
|
@Franziska-Mueller Great. Thank you |
…ets, and required access assets for improved efficiency.
…on` methods for consistency and clarity. Introduce expanded auction getter methods. Update related tests and assertions.
…ostromoAuction` tests for clarity and consistency.
…eflect revised wallet IDs.
…s. Update tests and logging to validate outputs and ensure consistent error propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the auction part has been implemented: Proposal
Fixes for Verify