IPO QDuel #705
Open
IPO QDuel #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-010
force-pushed
the
feature/2025-12-25-QDuel
branch
from
f6f0d80 to
bf89227
Compare
Contributor
Author
|
@Franziska-Mueller Please do a review |
| } | ||
|
|
||
| protected: | ||
| HashMap<id, RoomInfo, QDUEL_MAX_NUMBER_OF_ROOMS> rooms; |
Collaborator
There was a problem hiding this comment.
since you are removing items from these HashMap, please use cleanup or cleanupIfNeeded as specified in our documentation: https://github.com/qubic/core/blob/main/doc/contracts.md#container-types
| @@ -0,0 +1,1122 @@ | |||
| #define NO_UEFI | |||
| #define _ALLOW_KEYWORD_MACROS | |||
| #define private protected | |||
Collaborator
There was a problem hiding this comment.
why do you need this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal