toolkit/events: log/slog API #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a different API to the `toolkit/events` package that forwards to a `slog.Handler` extracted from a `context.Context`. This deprecates the (unused) `Group`/`Sink`/`Event` architecture in favor of a much simpler facade. The end goal of this addition is to allow claircore components to emit events into a separate per-request (whatever that means) event stream. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Member
Author
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a different API to the
toolkit/eventspackage thatforwards to a
slog.Handlerextracted from acontext.Context. Thisdeprecates the (unused)
Group/Sink/Eventarchitecture in favor ofa much simpler facade.
The end goal of this addition is to allow claircore components to emit
events into a separate per-request (whatever that means) event stream.