Draft
Conversation
And use some common actions that handle multiple OSes setup
The fuzz crate uses #![no_main] which causes linker errors on Windows when built with `cargo build`. While Linux/Mac linkers seems to be permissive and allow this, the resulting binaries are probably non-functional. It seems fuzz targets should only be built with `cargo fuzz` as the directory README explain
Author
|
So now this run test on windows. I need to make an adjustment to the And this confirm some of the tests are not passing. Maybe they should be fixed before merging this |
Author
|
I wonder if this could be usual multi os project and related to line ending difference. Especially as some of the failing test are snapshot test. And also to check the path separator |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And use some common actions that handle multiple OSes setup