[backport] Fix Windows paths with accented characters breaking dart-sass#14274
Merged
[backport] Fix Windows paths with accented characters breaking dart-sass#14274
Conversation
safeWindowsExec writes temp .bat files as UTF-8 (Deno default), but cmd.exe reads them using the OEM code page (e.g., CP850). Multi-byte UTF-8 characters like é (0xC3 0xA9) get misinterpreted, breaking paths with accented characters (e.g., C:\Users\Sébastien\). Add `chcp 65001 >nul` to switch cmd.exe to UTF-8 before the command line is parsed. Use CRLF line endings for correct .bat parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Backport from #14273
On Windows,
safeWindowsExecwrites temp.batfiles as UTF-8 butcmd.exereads them using OEM code page (CP850), garbling accented characters in paths (e.g.,C:\Users\Sébastien\).Adds
chcp 65001 >nulto switchcmd.exeto UTF-8 before the command line is parsed. Uses CRLF line endings for correct batch parsing.The full fix on main (#14273) also bypasses
sass.batentirely by callingdart.exedirectly — that larger change is not backported here.Fixes #14267