fix(extension): quarto use template failed correctly copy extensions when scoped in organisation/owner name#14010
Open
mcanouil wants to merge 4 commits intoquarto-dev:mainfrom
Open
fix(extension): quarto use template failed correctly copy extensions when scoped in organisation/owner name#14010mcanouil wants to merge 4 commits intoquarto-dev:mainfrom
quarto use template failed correctly copy extensions when scoped in organisation/owner name#14010mcanouil wants to merge 4 commits intoquarto-dev:mainfrom
Conversation
…ls to copy extensions Fixes quarto-dev#14008
Update the template tests to dynamically handle multiple extensions. This change improves test coverage and ensures that both 'jasa' and 'acm' templates are validated correctly.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
quarto use templatecommand previously created an empty_extensionsfolder and failed to copy the necessary extension's resource (e.g.,quarto-journals/acm) because of two things:copyExtensionswas not the one leading to_extensions/_extensions/quarto-journals/acm/, not in_extensions/acm/.Update the
quarto use templatetest to properly test that the extension (the manifest to be accurate) is properly copied for both "jasa" (correct/expected structure) and "acm".Fixes #14008