Use a safer, two-stage transformation in readqmd.lua
#13792
Merged
+126
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids us clobbering the existing Markdown structure when shortcodes are invoked inside link targets. Pandoc 3.7 and later are more strict in where spaces can appear inside links and image targets, and this transformation should now work in that setting.
cscheid
changed the title
readqmd.lua
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids us clobbering the existing Markdown structure when shortcodes are invoked inside link targets. Pandoc 3.7 and later are more strict in where spaces can appear inside links and image targets, and this transformation should now work in that setting. (thanks @vezwork for the idea!)
When merged, this should allow us to safely upgrade Pandoc.